From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVDHF-0003iE-62 for barebox@lists.infradead.org; Wed, 21 Oct 2020 12:31:38 +0000 Date: Wed, 21 Oct 2020 14:31:35 +0200 From: Sascha Hauer Message-ID: <20201021123135.GH26805@pengutronix.de> References: <20201020111537.29328-1-u.kleine-koenig@pengutronix.de> <20201021100548.GA26805@pengutronix.de> <20201021120343.46wzcympd6r673lo@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021120343.46wzcympd6r673lo@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usb: i.MX: improve regulator handling To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: barebox@lists.infradead.org On Wed, Oct 21, 2020 at 02:03:43PM +0200, Uwe Kleine-K=F6nig wrote: > On Wed, Oct 21, 2020 at 12:05:48PM +0200, Sascha Hauer wrote: > > On Tue, Oct 20, 2020 at 01:15:37PM +0200, Uwe Kleine-K=F6nig wrote: > > > Instead of just ignoring errors related to regulator getting error ou= t. > > > In case there is no regulator in the device tree, regulator_get() ret= urns > > > the dummy regulator and not an error code, so the change is right for > > > this situation, too. > > > = > > > Signed-off-by: Uwe Kleine-K=F6nig > > > --- > > > drivers/usb/imx/chipidea-imx.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > = > > > diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipide= a-imx.c > > > index 786beede6d89..dd0e3c1a2a58 100644 > > > --- a/drivers/usb/imx/chipidea-imx.c > > > +++ b/drivers/usb/imx/chipidea-imx.c > > > @@ -267,8 +267,11 @@ static int imx_chipidea_probe(struct device_d *d= ev) > > > } > > > = > > > ci->vbus =3D regulator_get(dev, "vbus"); > > > - if (IS_ERR(ci->vbus)) > > > - ci->vbus =3D NULL; > > > + if (IS_ERR(ci->vbus)) { > > > + ret =3D ERR_PTR(ci->vbus); > > > + dev_err(dev, "Cannot get vbus regulator: %s\n", strerror(-ret)); > > > + return ret; > > > + } > > = > > Ok, as Marco noted we had regressions in similar cases where we didn't > > have a driver for the regulator, but knew that it was default enabled. > > Therefore I am dropping this patch. > = > So you prefer "fails on some boards with a missleading (or at least > little helpful) error message" over "fails on some (other) boards with > an obvious error indication"? > = > I think I would have decided this differently. And IMHO then this should > at least result in a runtime warning instead of being silently > optimistic. Have a look at what I suggested in my other mail. With an additional device tree property saying "barebox: Ignore absent regulator" I would have a way telling people how to fix the regression. With that implemented we could merge your patch. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox