From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzc6g-0003Hs-PG for barebox@lists.infradead.org; Wed, 13 Jan 2021 09:06:24 +0000 Date: Wed, 13 Jan 2021 10:06:21 +0100 Message-ID: <20210113090621.GI19063@pengutronix.de> References: <20210112093801.2632-1-str@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210112093801.2632-1-str@pengutronix.de> From: Sascha Hauer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] imd: change disabled checksum tag info to debug To: Steffen Trumtrar Cc: barebox@lists.infradead.org, Steffen Trumtrar On Tue, Jan 12, 2021 at 10:38:01AM +0100, Steffen Trumtrar wrote: > From: Steffen Trumtrar > > When the checksum tag is disabled the CRC is most likely invalid. > And if the checksum tag is disabled and the CRC is actually invalid the > user doesn't care for it anyway. > > This information only confuses the user so make it a debug message. > > Signed-off-by: Steffen Trumtrar > --- > common/imd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks Sascha > > diff --git a/common/imd.c b/common/imd.c > index ef9eff876b..aff3b00b6b 100644 > --- a/common/imd.c > +++ b/common/imd.c > @@ -406,7 +406,7 @@ int imd_verify_crc32(void *buf, size_t size) > *p, crc); > return -EILSEQ; > } else if (*p != crc && !imd_crc32_is_valid(*flags)) { > - printf("CRC: is invalid, but the checksum tag is not enabled\n"); > + debug("CRC: is invalid, but the checksum tag is not enabled\n"); > return -EINVAL; > } else { > printf("CRC: valid\n"); > -- > 2.20.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox