From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1pOl-00053K-Bk for barebox@lists.infradead.org; Tue, 19 Jan 2021 11:42:12 +0000 Date: Tue, 19 Jan 2021 12:42:08 +0100 From: Marco Felsch Message-ID: <20210119114208.6kxdsj5pa5zo25qo@pengutronix.de> References: <20210118204850.8420-1-m.felsch@pengutronix.de> <20210119110134.GX19063@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119110134.GX19063@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] blspec: allow board files to overwrite config file settings To: Sascha Hauer Cc: barebox@lists.infradead.org Hi Sascha, On 21-01-19 12:01, Sascha Hauer wrote: > Hi Marco, > On Mon, Jan 18, 2021 at 09:48:49PM +0100, Marco Felsch wrote: > > This commit adds the support to overwrite and/or adapt blspec config > > files by the following global variables: > > - global.blspec.fixup.devicetree > > - global.blspec.fixup.initrd > > - global.blspec.fixup.options > > - global.blspec.fixup.linux > > - global.blspec.fixup.devicetree-overlay. > > > > Overwriting blspec-config's shouldn't be the normal case but there are > > cases where this support is needed. One use-case can be a special > > handling during update. E.g. the normal boot-flow don't need the initrd > > but the update-flow uses it because the update system is on the initrd. > > When you have an update system and a regular system on the same > filesystem then I would expect an additional bootspec entry for the > update system. AFAIK, barebox tries to find the correct entry by checking all config files and loads the first matching config file. Is there a way to specify an explicite config file? > > Another use-case could be a dynamic devicetree-overlay handling. E.g. > > the board code dynamically checks which periphery boards are connected > > and adds the required overlays dynamically. > > Board code can register overlays already, there's no need for bootspec > to do that. But this needs a lot more handling if we boot from nfs or from emmc. Therefore I utilized the already existing code :) > Overall overwriting bootspec variables somewhat contradicts the whole > purpose of bootspec. I don't like that very much, so you'll need very > good reasons to get this through ;) Yep, I thought so ;) Therefore I wrote a big warning. It gives you a lot opportunities to shot yourself in the foot. Therefore I print a warning if you overwrite a already exisiting config. Regards, Marco _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox