From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yZ3-0003rx-8n for barebox@lists.infradead.org; Mon, 25 Jan 2021 09:53:42 +0000 Date: Mon, 25 Jan 2021 10:53:39 +0100 Message-ID: <20210125095339.GE31738@pengutronix.de> References: <20210118190923.531-1-m.grzeschik@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118190923.531-1-m.grzeschik@pengutronix.de> From: Sascha Hauer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usb: hub: fix state change check for not powercycled ports To: Michael Grzeschik Cc: barebox@lists.infradead.org On Mon, Jan 18, 2021 at 08:09:23PM +0100, Michael Grzeschik wrote: > Since we don't power cycle the ports on start since patch "19bb0b2a usb: > hub: Do not power-cycle usb devices on init" it is possible that the > device on this port is already active from a previous enumeration. This > way barebox will never get any change in USB_PORT_STAT_C_CONNECTION bit > change. > > Although the device will probably still work fine after the following > port reset, the current code will always miss reenumerating these still > plugged devices. This patch fixes this by ignoring the check for > STAT_C_CONNECTION bit and only go for USB_PORT_STAT_CONNECTION which > should be enough. > > Signed-off-by: Michael Grzeschik > --- > drivers/usb/core/hub.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 01653d8c20..d1112248ee 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -336,8 +336,7 @@ static void usb_scan_port(struct usb_device_scan *usb_scan) > dev_dbg(&dev->dev, "port%d: Status 0x%04x Change 0x%04x\n", > port + 1, portstatus, portchange); > > - if (!(portchange & USB_PORT_STAT_C_CONNECTION) || > - !(portstatus & USB_PORT_STAT_CONNECTION)) { > + if (!(portstatus & USB_PORT_STAT_CONNECTION)) { > if (get_time_ns() >= hub->connect_timeout) { > dev_dbg(&dev->dev, "port%d: timeout\n", port + 1); > /* Remove this device from scanning list */ > -- > 2.30.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox