From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([85.220.165.71]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6UoJ-00029M-Vn for barebox@lists.infradead.org; Mon, 01 Feb 2021 08:43:52 +0000 Date: Mon, 1 Feb 2021 09:43:50 +0100 Message-ID: <20210201084350.GK19583@pengutronix.de> References: <20210129135833.5748-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210129135833.5748-1-a.fatoum@pengutronix.de> From: Sascha Hauer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] efi: declare prototype for close_protocol BootService To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Fri, Jan 29, 2021 at 02:58:33PM +0100, Ahmad Fatoum wrote: > Sometimes, drivers need to probe whether the EFI device in front of them > is the actual hardware they expect. If it's not, the driver should call > close_protocol to leave the decision on whether to match this device to > another driver. Use the correct type for close_protocol to facilitate > this. > > No functional change, as no in-tree driver makes use of this yet. > > Signed-off-by: Ahmad Fatoum > --- > include/efi.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/include/efi.h b/include/efi.h > index 43c05939513d..f6833fde1e75 100644 > --- a/include/efi.h > +++ b/include/efi.h > @@ -256,7 +256,8 @@ typedef struct { > efi_status_t (EFIAPI *open_protocol)(efi_handle_t handle, efi_guid_t *protocol, > void ** interface, efi_handle_t agent_handle, > efi_handle_t controller_handle, u32 attributes); > - void *close_protocol; > + efi_status_t (EFIAPI *close_protocol)(efi_handle_t handle, efi_guid_t *protocol, > + efi_handle_t agent, efi_handle_t controller); > efi_status_t(EFIAPI *open_protocol_information)(efi_handle_t handle, efi_guid_t *Protocol, > struct efi_open_protocol_information_entry **entry_buffer, > unsigned long *entry_count); > -- > 2.30.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox