mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell
@ 2021-04-04 11:18 Ahmad Fatoum
  2021-04-04 11:18 ` [PATCH 2/2] sandbox: state: reword warning about initial state errors Ahmad Fatoum
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2021-04-04 11:18 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

barebox on sandbox defaults to network boot, which fails either due to
missing TAP support (like not having CAP_NET_ADMIN) or because the files
couldn't be fetched.

Arguably, the most user-friendly thing is to drop to shell. Do so.
Users can still override nv.autoboot if they want to boot differently.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 arch/sandbox/board/env/nv/autoboot | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 arch/sandbox/board/env/nv/autoboot

diff --git a/arch/sandbox/board/env/nv/autoboot b/arch/sandbox/board/env/nv/autoboot
new file mode 100644
index 000000000000..f7d13fd04662
--- /dev/null
+++ b/arch/sandbox/board/env/nv/autoboot
@@ -0,0 +1 @@
+abort
-- 
2.30.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] sandbox: state: reword warning about initial state errors
  2021-04-04 11:18 [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Ahmad Fatoum
@ 2021-04-04 11:18 ` Ahmad Fatoum
  2021-04-07 10:59 ` [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Uwe Kleine-König
  2021-04-13  7:43 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2021-04-04 11:18 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The message didn't explicitly say it is expected behavior to not find
barebox-state on startup. Reword the message to make this clearer.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 arch/sandbox/board/env/init/state | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/sandbox/board/env/init/state b/arch/sandbox/board/env/init/state
index 0b8e40409f97..b8a2b42a53ea 100644
--- a/arch/sandbox/board/env/init/state
+++ b/arch/sandbox/board/env/init/state
@@ -5,8 +5,9 @@ fi
 source /env/data/ansi-colors
 
 echo -e $CYAN
-echo "******************************************************************"
-echo "*** Inconsistent barebox state buckets detected on first boot ***"
-echo "***         barebox will repair them on next shutdown         ***"
-echo "*****************************************************************"
+echo "*******************************************************"
+echo "***   Inconsistent barebox state buckets detected   ***"
+echo "***         This is normal for a first boot         ***"
+echo "*** barebox will repair them on next poweroff/reset ***"
+echo "*******************************************************"
 echo -e -n $NC
-- 
2.30.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell
  2021-04-04 11:18 [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Ahmad Fatoum
  2021-04-04 11:18 ` [PATCH 2/2] sandbox: state: reword warning about initial state errors Ahmad Fatoum
@ 2021-04-07 10:59 ` Uwe Kleine-König
  2021-04-13  7:43 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2021-04-07 10:59 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox


[-- Attachment #1.1: Type: text/plain, Size: 678 bytes --]

On Sun, Apr 04, 2021 at 01:18:30PM +0200, Ahmad Fatoum wrote:
> barebox on sandbox defaults to network boot, which fails either due to
> missing TAP support (like not having CAP_NET_ADMIN) or because the files
> couldn't be fetched.
> 
> Arguably, the most user-friendly thing is to drop to shell. Do so.
> Users can still override nv.autoboot if they want to boot differently.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell
  2021-04-04 11:18 [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Ahmad Fatoum
  2021-04-04 11:18 ` [PATCH 2/2] sandbox: state: reword warning about initial state errors Ahmad Fatoum
  2021-04-07 10:59 ` [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Uwe Kleine-König
@ 2021-04-13  7:43 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2021-04-13  7:43 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Sun, Apr 04, 2021 at 01:18:30PM +0200, Ahmad Fatoum wrote:
> barebox on sandbox defaults to network boot, which fails either due to
> missing TAP support (like not having CAP_NET_ADMIN) or because the files
> couldn't be fetched.
> 
> Arguably, the most user-friendly thing is to drop to shell. Do so.
> Users can still override nv.autoboot if they want to boot differently.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  arch/sandbox/board/env/nv/autoboot | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 arch/sandbox/board/env/nv/autoboot

Applied, thanks

Sascha

> 
> diff --git a/arch/sandbox/board/env/nv/autoboot b/arch/sandbox/board/env/nv/autoboot
> new file mode 100644
> index 000000000000..f7d13fd04662
> --- /dev/null
> +++ b/arch/sandbox/board/env/nv/autoboot
> @@ -0,0 +1 @@
> +abort
> -- 
> 2.30.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-13  7:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 11:18 [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Ahmad Fatoum
2021-04-04 11:18 ` [PATCH 2/2] sandbox: state: reword warning about initial state errors Ahmad Fatoum
2021-04-07 10:59 ` [PATCH 1/2] sandbox: env: set nv.autoboot=abort to drop to shell Uwe Kleine-König
2021-04-13  7:43 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox