From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 16 Apr 2021 12:00:44 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lXLHI-0001D3-Qk for lore@lore.pengutronix.de; Fri, 16 Apr 2021 12:00:44 +0200 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXLHI-0007DQ-33 for lore@pengutronix.de; Fri, 16 Apr 2021 12:00:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1xHj4zSLVjDh7t3ctS8QLyPq6itI9vVaGyFDl3VjpIo=; b=kcwy+o2nAjI/ysSXBjcasqH4Q 491xHLpvzjFVuDIfV8GvLKifs7s/kFAlScd26YmHJHV6UJWmGtTqDjIKKu/BSgqRGXCVszde4ywuR VxaD7mN4v0vPWhw49p63MTNNn3QpUVV03eGfe1pDflplrhgn+XexDphKqjvMXx+FktWRl5sNlep9c SHf+dqdLRKg0Jc1s/sPkZVJEGz9nPSKzy/6BCTk/PjumKyznpQhy7xSn9hycaJnM0dbILdZ1sOdVK U1o8bVkwl6XzL3l1LjgHnZuWJ6p//BbexJHGHwfAwMDKt0Xi97iQxdjH1bvmSenbYOT3jsoufwWh7 iA4Hru78A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXLFw-001eeC-O1; Fri, 16 Apr 2021 09:59:21 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXL7Y-001cVl-3D for barebox@desiato.infradead.org; Fri, 16 Apr 2021 09:50:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=EzHjne4EzbADfWLqm3nMwG16UyBT0mWm61kisS+Nito=; b=WvI5BiG4GsNQf9C1dp+RpMeOb/ LAoNf+R5rkqUdVtLGDDcNccCAoAgCFcZL3N32wjnEBAwNmrcEnWE06zW0yaWNiAUmN2149QC2V3CX jkue+Wyyf5WdCGf+FHu0QBs86FkV2JCCmruCzg+6bApfoSlFKG157WSpju2rXFo8p0o7MdSGHlnH7 WQuC5QD/68G7xTrEUzq9jzxZEm8fDEbFU+YGoWfZV4pa0f+Z7SGRk5opZYTRcwjdrebgePcxxsTsR ZCjpdztQizScKnxU5QWx438io0gH88YDNgxx2UIBWv+666HLPQDfKbHRh1pcUylNLLb4ZZa+Mt3sG T6C0Vuyw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXL7V-009G0A-Fs for barebox@lists.infradead.org; Fri, 16 Apr 2021 09:50:38 +0000 Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXL7D-00051K-Uq; Fri, 16 Apr 2021 11:50:19 +0200 Received: from sha by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lXL7C-0001DX-Qv; Fri, 16 Apr 2021 11:50:18 +0200 From: Sascha Hauer To: Barebox List Date: Fri, 16 Apr 2021 11:49:31 +0200 Message-Id: <20210416094943.3648-6-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210416094943.3648-1-s.hauer@pengutronix.de> References: <20210416094943.3648-1-s.hauer@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_025037_547015_626FF60D X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Felsch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2001:8b0:10b:1:d65d:64ff:fe57:4e05 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 05/17] of: base: move clock init from of_probe() to barebox_register_of() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) From: Marco Felsch This is required for the new deep-probe mechanism. Barebox deep-probe calls of_probe() very late and so clock drivers using the old CLK_OF_DECLARE_DRIVER() mechanism are added very late. This would break the deep-probe approach. Move of_clk_init() and call it right before of_probe() should have no impact because of_clk_init() depends only on an unflatten dtb. Signed-off-by: Marco Felsch Link: https://lore.pengutronix.de/20201021115813.31645-6-m.felsch@pengutronix.de Signed-off-by: Sascha Hauer --- drivers/of/base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 549a0a2c2c..7b3cfa8393 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1707,8 +1707,10 @@ void barebox_register_of(struct device_node *root) of_set_root_node(root); of_fix_tree(root); - if (IS_ENABLED(CONFIG_OFDEVICE)) + if (IS_ENABLED(CONFIG_OFDEVICE)) { + of_clk_init(root, NULL); of_probe(); + } } void barebox_register_fdt(const void *dtb) @@ -2335,7 +2337,6 @@ int of_probe(void) of_platform_device_create_root(root_node); - of_clk_init(root_node, NULL); of_platform_populate(root_node, of_default_bus_match_table, NULL); return 0; -- 2.29.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox