From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] scripts/spdxcheck.py: Use Python 3
Date: Wed, 28 Apr 2021 07:39:11 +0300 [thread overview]
Message-ID: <20210428073911.122e5bd2dd27df3ec6bf6873@gmail.com> (raw)
In-Reply-To: <20210416091404.92251-1-antonynpavlov@gmail.com>
On Fri, 16 Apr 2021 12:14:04 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
ping
> Based on this linux kernel commit:
>
> > commit d0259c42abff51b586496a0594933e394efefbc5
> > Author: Bert Vermeulen <bert@biot.com>
> > Date: Thu Jan 21 09:54:12 2021 +0100
> >
> > spdxcheck.py: Use Python 3
> >
> > Python 2.x has been officially EOL'ed for some time, and in any case
> > the git module for it is hard to come by.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> scripts/checkpatch.pl | 4 ++--
> scripts/spdxcheck.py | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b8bd4e1a59..36e3d768f3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -885,10 +885,10 @@ sub is_maintained_obsolete {
> sub is_SPDX_License_valid {
> my ($license) = @_;
>
> - return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
> + return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
>
> my $root_path = abs_path($root);
> - my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
> + my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
> return 0 if ($status ne "");
> return 1;
> }
> diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> index 6374e078a5..0f81337394 100755
> --- a/scripts/spdxcheck.py
> +++ b/scripts/spdxcheck.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
> # SPDX-License-Identifier: GPL-2.0
> # Copyright Thomas Gleixner <tglx@linutronix.de>
>
> --
> 2.31.0
>
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-04-28 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:14 Antony Pavlov
2021-04-28 4:39 ` Antony Pavlov [this message]
2021-04-28 8:07 ` Lucas Stach
2021-04-28 5:56 ` Uwe Kleine-König
2021-05-03 12:02 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428073911.122e5bd2dd27df3ec6bf6873@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox