* [PATCH] scripts/spdxcheck.py: Use Python 3
@ 2021-04-16 9:14 Antony Pavlov
2021-04-28 4:39 ` Antony Pavlov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Antony Pavlov @ 2021-04-16 9:14 UTC (permalink / raw)
To: barebox; +Cc: Uwe Kleine-König
Based on this linux kernel commit:
> commit d0259c42abff51b586496a0594933e394efefbc5
> Author: Bert Vermeulen <bert@biot.com>
> Date: Thu Jan 21 09:54:12 2021 +0100
>
> spdxcheck.py: Use Python 3
>
> Python 2.x has been officially EOL'ed for some time, and in any case
> the git module for it is hard to come by.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
scripts/checkpatch.pl | 4 ++--
scripts/spdxcheck.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b8bd4e1a59..36e3d768f3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -885,10 +885,10 @@ sub is_maintained_obsolete {
sub is_SPDX_License_valid {
my ($license) = @_;
- return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
+ return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
my $root_path = abs_path($root);
- my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
+ my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
return 0 if ($status ne "");
return 1;
}
diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
index 6374e078a5..0f81337394 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0
# Copyright Thomas Gleixner <tglx@linutronix.de>
--
2.31.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] scripts/spdxcheck.py: Use Python 3
2021-04-16 9:14 [PATCH] scripts/spdxcheck.py: Use Python 3 Antony Pavlov
@ 2021-04-28 4:39 ` Antony Pavlov
2021-04-28 8:07 ` Lucas Stach
2021-04-28 5:56 ` Uwe Kleine-König
2021-05-03 12:02 ` Sascha Hauer
2 siblings, 1 reply; 5+ messages in thread
From: Antony Pavlov @ 2021-04-28 4:39 UTC (permalink / raw)
To: barebox, Sascha Hauer, Uwe Kleine-König
On Fri, 16 Apr 2021 12:14:04 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
ping
> Based on this linux kernel commit:
>
> > commit d0259c42abff51b586496a0594933e394efefbc5
> > Author: Bert Vermeulen <bert@biot.com>
> > Date: Thu Jan 21 09:54:12 2021 +0100
> >
> > spdxcheck.py: Use Python 3
> >
> > Python 2.x has been officially EOL'ed for some time, and in any case
> > the git module for it is hard to come by.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> scripts/checkpatch.pl | 4 ++--
> scripts/spdxcheck.py | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b8bd4e1a59..36e3d768f3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -885,10 +885,10 @@ sub is_maintained_obsolete {
> sub is_SPDX_License_valid {
> my ($license) = @_;
>
> - return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
> + return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
>
> my $root_path = abs_path($root);
> - my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
> + my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
> return 0 if ($status ne "");
> return 1;
> }
> diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> index 6374e078a5..0f81337394 100755
> --- a/scripts/spdxcheck.py
> +++ b/scripts/spdxcheck.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
> # SPDX-License-Identifier: GPL-2.0
> # Copyright Thomas Gleixner <tglx@linutronix.de>
>
> --
> 2.31.0
>
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] scripts/spdxcheck.py: Use Python 3
2021-04-28 4:39 ` Antony Pavlov
@ 2021-04-28 8:07 ` Lucas Stach
0 siblings, 0 replies; 5+ messages in thread
From: Lucas Stach @ 2021-04-28 8:07 UTC (permalink / raw)
To: Antony Pavlov, barebox
Hi Antony,
Am Mittwoch, dem 28.04.2021 um 07:39 +0300 schrieb Antony Pavlov:
> On Fri, 16 Apr 2021 12:14:04 +0300
> Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> ping
Please be patient. Sascha is out sick, but should be back next week.
Regards,
Lucas
> > Based on this linux kernel commit:
> >
> > > commit d0259c42abff51b586496a0594933e394efefbc5
> > > Author: Bert Vermeulen <bert@biot.com>
> > > Date: Thu Jan 21 09:54:12 2021 +0100
> > >
> > > spdxcheck.py: Use Python 3
> > >
> > > Python 2.x has been officially EOL'ed for some time, and in any case
> > > the git module for it is hard to come by.
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > scripts/checkpatch.pl | 4 ++--
> > scripts/spdxcheck.py | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index b8bd4e1a59..36e3d768f3 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -885,10 +885,10 @@ sub is_maintained_obsolete {
> > sub is_SPDX_License_valid {
> > my ($license) = @_;
> >
> >
> >
> >
> > - return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
> > + return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
> >
> >
> >
> >
> > my $root_path = abs_path($root);
> > - my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
> > + my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
> > return 0 if ($status ne "");
> > return 1;
> > }
> > diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> > index 6374e078a5..0f81337394 100755
> > --- a/scripts/spdxcheck.py
> > +++ b/scripts/spdxcheck.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> > # SPDX-License-Identifier: GPL-2.0
> > # Copyright Thomas Gleixner <tglx@linutronix.de>
> >
> >
> >
> >
> > --
> > 2.31.0
> >
>
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/spdxcheck.py: Use Python 3
2021-04-16 9:14 [PATCH] scripts/spdxcheck.py: Use Python 3 Antony Pavlov
2021-04-28 4:39 ` Antony Pavlov
@ 2021-04-28 5:56 ` Uwe Kleine-König
2021-05-03 12:02 ` Sascha Hauer
2 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2021-04-28 5:56 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
On Fri, Apr 16, 2021 at 12:14:04PM +0300, Antony Pavlov wrote:
> Based on this linux kernel commit:
>
> > commit d0259c42abff51b586496a0594933e394efefbc5
> > Author: Bert Vermeulen <bert@biot.com>
> > Date: Thu Jan 21 09:54:12 2021 +0100
> >
> > spdxcheck.py: Use Python 3
> >
> > Python 2.x has been officially EOL'ed for some time, and in any case
> > the git module for it is hard to come by.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/spdxcheck.py: Use Python 3
2021-04-16 9:14 [PATCH] scripts/spdxcheck.py: Use Python 3 Antony Pavlov
2021-04-28 4:39 ` Antony Pavlov
2021-04-28 5:56 ` Uwe Kleine-König
@ 2021-05-03 12:02 ` Sascha Hauer
2 siblings, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2021-05-03 12:02 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox, Uwe Kleine-König
On Fri, Apr 16, 2021 at 12:14:04PM +0300, Antony Pavlov wrote:
> Based on this linux kernel commit:
>
> > commit d0259c42abff51b586496a0594933e394efefbc5
> > Author: Bert Vermeulen <bert@biot.com>
> > Date: Thu Jan 21 09:54:12 2021 +0100
> >
> > spdxcheck.py: Use Python 3
> >
> > Python 2.x has been officially EOL'ed for some time, and in any case
> > the git module for it is hard to come by.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> scripts/checkpatch.pl | 4 ++--
> scripts/spdxcheck.py | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-03 12:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 9:14 [PATCH] scripts/spdxcheck.py: Use Python 3 Antony Pavlov
2021-04-28 4:39 ` Antony Pavlov
2021-04-28 8:07 ` Lucas Stach
2021-04-28 5:56 ` Uwe Kleine-König
2021-05-03 12:02 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox