From: Sascha Hauer <sha@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] watchdog: imxwd: get and enable clock
Date: Mon, 3 May 2021 13:43:24 +0200 [thread overview]
Message-ID: <20210503114324.GD19819@pengutronix.de> (raw)
In-Reply-To: <20210419123747.2373-1-s.trumtrar@pengutronix.de>
On Mon, Apr 19, 2021 at 02:37:47PM +0200, Steffen Trumtrar wrote:
> This it (at least) necessary for i.MX7s or otherwise barebox will hang
> when trying to access the registers of WDOG2/3/4.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> drivers/watchdog/imxwd.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
> index b2cfd1cd3a31..26c62b7bcb31 100644
> --- a/drivers/watchdog/imxwd.c
> +++ b/drivers/watchdog/imxwd.c
> @@ -21,6 +21,7 @@
> #include <restart.h>
> #include <watchdog.h>
> #include <reset_source.h>
> +#include <linux/clk.h>
>
> struct imx_wd;
>
> @@ -224,6 +225,7 @@ static int imx_wd_probe(struct device_d *dev)
> {
> struct resource *iores;
> struct imx_wd *priv;
> + struct clk *clk;
> void *ops;
> int ret;
>
> @@ -237,6 +239,15 @@ static int imx_wd_probe(struct device_d *dev)
> dev_err(dev, "could not get memory region\n");
> return PTR_ERR(iores);
> }
> +
> + clk = clk_get(dev, NULL);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
> +
> + ret = clk_enable(clk);
> + if (ret)
> + return ret;
> +
> priv->base = IOMEM(iores->start);
> priv->ops = ops;
> priv->wd.set_timeout = imx_watchdog_set_timeout;
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-05-03 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 12:37 Steffen Trumtrar
2021-05-03 11:43 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503114324.GD19819@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox