mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Roland Hieber <rhi@pengutronix.de>, Joel Stanley <joel@jms.id.au>
Cc: barebox@lists.infradead.org, Marek Czerski <m.czerski@ap-tech.pl>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 6/9] net: add LiteEth driver
Date: Thu, 6 May 2021 14:33:22 +0300	[thread overview]
Message-ID: <20210506143322.bd692fce2559d6cf83b117bf@gmail.com> (raw)
In-Reply-To: <20210506101038.hq4rqkbl6w7wljqb@pengutronix.de>

On Thu, 6 May 2021 12:10:38 +0200
Roland Hieber <rhi@pengutronix.de> wrote:

Hi !

> On Wed, May 05, 2021 at 01:08:57PM +0300, Antony Pavlov wrote:
> > LiteEth provides a small footprint and configurable Ethernet core.
> > 
> > LiteEth is part of LiteX libraries whose aims are to lower entry level of
> > complex FPGA cores by providing simple, elegant and efficient implementations
> > of components used in today's SoC such as Ethernet, SATA, PCIe, SDRAM Controller...
> > 
> > Using Migen to describe the HDL allows the core to be highly and easily configurable.
> > 
> > LiteEth can be used as LiteX library or can be integrated with your standard
> > design flow by generating the verilog rtl that you will use as a standard core.
> > 
> > See https://github.com/enjoy-digital/liteeth for details.
> > 
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > Signed-off-by: Marek Czerski <m.czerski@ap-tech.pl>
> > ---
> >  drivers/net/Kconfig   |   8 +
> >  drivers/net/Makefile  |   1 +
> >  drivers/net/liteeth.c | 376 ++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 385 insertions(+)
> > 
> > Cc: Marek Czerski <m.czerski@ap-tech.pl>
> > 
...
> > diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> > index 656d45a868..bb751943f6 100644
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -36,3 +36,4 @@ obj-$(CONFIG_DRIVER_NET_TAP)		+= tap.o
> >  obj-$(CONFIG_DRIVER_NET_TSE)		+= altera_tse.o
> >  obj-$(CONFIG_DRIVER_NET_EFI_SNP)	+= efi-snp.o
> >  obj-$(CONFIG_DRIVER_NET_AG71XX)		+= ag71xx.o
> > +obj-$(CONFIG_DRIVER_NET_LITEETH)	+= liteeth.o
> > diff --git a/drivers/net/liteeth.c b/drivers/net/liteeth.c
> > new file mode 100644
> > index 0000000000..137cb854c5
> > --- /dev/null
> > +++ b/drivers/net/liteeth.c
> > @@ -0,0 +1,376 @@
> > +/*
> 
> Could you please add an SPDX-License-Identifier header [1] here? (Maybe
> also for other newly introduced files in this series, haven't checked.)
> 
> [1]: https://www.kernel.org/doc/html/latest/process/license-rules.html
> 

Original driver by Joel Stanley contains MODULE_LICENSE("GPL").
This is a bit confusing because I can't determine exact GPL version.

To: Joel Stanley

Can I add `SPDX-License-Identifier: GPL-2.0-or-later` or
`SPDX-License-Identifier: GPL-2.0-only` to the LiteEth barebox driver header?


> > + * LiteX Liteeth Ethernet
> > + *
> > + * Copyright 2017 Joel Stanley <joel@jms.id.au>
> > + *
> > + * Ported to barebox from linux kernel
> > + *   Copyright (C) 2019-2021 Antony Pavlov <antonynpavlov@gmail.com>
> > + *   Copyright (C) 2021 Marek Czerski <m.czerski@ap-tech.pl>
> > + *
> > + */

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-05-06 11:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 10:08 [PATCH 0/9] RISC-V: add LiteX SoC support; resurrect nmon Antony Pavlov
2021-05-05 10:08 ` [PATCH 1/9] RISC-V: make it possible to run nmon from PBL C code Antony Pavlov
2021-05-05 10:27   ` Ahmad Fatoum
2021-05-05 10:08 ` [PATCH 2/9] RISC-V: boards: erizo: make it possible to use nmon Antony Pavlov
2021-05-05 10:28   ` Ahmad Fatoum
2021-05-05 10:08 ` [PATCH 3/9] serial: add litex UART driver Antony Pavlov
2021-05-05 10:32   ` Ahmad Fatoum
2021-05-05 10:08 ` [PATCH 4/9] gpio: add driver for 74xx-ICs with MMIO access Antony Pavlov
2021-05-05 10:35   ` Ahmad Fatoum
2021-05-05 10:08 ` [PATCH 5/9] spi: add litex spiflash driver Antony Pavlov
2021-05-05 10:39   ` Ahmad Fatoum
2021-05-05 15:10     ` Antony Pavlov
2021-05-05 10:08 ` [PATCH 6/9] net: add LiteEth driver Antony Pavlov
2021-05-06 10:10   ` Roland Hieber
2021-05-06 11:33     ` Antony Pavlov [this message]
2021-05-05 10:08 ` [PATCH 7/9] RISC-V: add initial LiteX SoC support Antony Pavlov
2021-05-05 10:16   ` Ahmad Fatoum
2021-05-05 10:45   ` Jan Lübbe
2021-05-05 15:23     ` Antony Pavlov
2021-05-05 10:08 ` [PATCH 8/9] RISC-V: add litex-linux board support Antony Pavlov
2021-05-05 10:19   ` Ahmad Fatoum
2021-05-05 10:36     ` Antony Pavlov
2021-05-05 10:09 ` [PATCH 9/9] RISC-V: add litex_linux_defconfig Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506143322.bd692fce2559d6cf83b117bf@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=joel@jms.id.au \
    --cc=m.czerski@ap-tech.pl \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox