mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>
Cc: barebox@lists.infradead.org, a.fatoum@pengutronix.de
Subject: Re: [PATCH v2 1/2] of: fix up /chosen node even when there are no bootargs
Date: Wed, 26 May 2021 07:53:51 +0200	[thread overview]
Message-ID: <20210526055351.GX19819@pengutronix.de> (raw)
In-Reply-To: <b66b5544-ae32-7711-4920-65e63927a876@pengutronix.de>

On Tue, May 25, 2021 at 10:53:27AM +0200, Bastian Krause wrote:
> On 4/14/21 3:00 PM, Bastian Krause wrote:
> > From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > 
> > Currently the /chosen fixups of "reset-source",
> > "reset-source-instance", "reset-source-device" and "bootsource" do not
> > happen if no bootargs are available.
> > 
> > Fix that by moving the actual bootargs fixup to a dedicated function
> > of_write_bootargs() and only return there early on empty bootargs, but
> > still perform the /chosen fixups mentioned above.
> > 
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > [bst: dropped new line deletions and modified string comparison, moved of_write_bootargs() call to original position, add commit message]
> > Signed-off-by: Bastian Krause <bst@pengutronix.de>
> > ---
> > No changes since (implicit) v1.
> > ---
> >  common/oftree.c | 20 +++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> Gentle ping.

Sorry, missed these. Applied now, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-26  5:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 13:00 Bastian Krause
2021-04-14 13:00 ` [PATCH v2 2/2] of: introduce global.linux.bootargs_append Bastian Krause
2021-05-25  8:53   ` Bastian Krause
2021-05-25  8:53 ` [PATCH v2 1/2] of: fix up /chosen node even when there are no bootargs Bastian Krause
2021-05-26  5:53   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526055351.GX19819@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=bst@pengutronix.de \
    --subject='Re: [PATCH v2 1/2] of: fix up /chosen node even when there are no bootargs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox