From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 11 Jun 2021 13:54:18 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lrfju-0005fC-Fk for lore@lore.pengutronix.de; Fri, 11 Jun 2021 13:54:18 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrfjt-0003MI-Lg for lore@pengutronix.de; Fri, 11 Jun 2021 13:54:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wL0Y0H19Q0QMA5cGLOELZcpmjsE7TGyoRQ1I2f3m7Fc=; b=3qHe97RaeIpKfhMJCzBI8LTlKy 1HVgOL1hYdioML8AX++74kDBS3jDmwi/FQCpycs8xx0FpYYxBltTODiu4uXfgpGWVz2EDBMr9i1BZ GKs4g2BL3xsJlsLBKT8YGdKMKXwWbV7aAFitXBX8vBk63BucIP4ql5fYmiBJzFr/HPVbL+fwkLYJz c7shGfrJJdFzd/sOA5yGhgsnzP6AcCJYrW91HJytaCLQpSY/FPbmcRyqA+4DhXhD96hzAR8Wadf0x yB5cSPA78ZCY0oQgsOPFxtXiUnqP15hyn7KK4SkX/nUQmVlXAvVj1Oyzh2wJVFfOJU5B8NE6hWLQR MKscBHsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrfid-0057g2-VA; Fri, 11 Jun 2021 11:53:00 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrfiY-0057f9-LP for barebox@lists.infradead.org; Fri, 11 Jun 2021 11:52:56 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrfiX-0003IH-2I; Fri, 11 Jun 2021 13:52:53 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lrfiW-0006N5-Md; Fri, 11 Jun 2021 13:52:52 +0200 Date: Fri, 11 Jun 2021 13:52:52 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20210611115252.GE20470@pengutronix.de> References: <20210609174913.27194-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210609174913.27194-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:52:34 up 113 days, 15:16, 122 users, load average: 0.15, 0.11, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_045254_723749_92565D2F X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] fixup! pinctrl: Rockchip: Update from Linux X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Wed, Jun 09, 2021 at 07:49:13PM +0200, Ahmad Fatoum wrote: > The original code uses regmap for the base address and reg for the > offset to add onto it. The barebox port combines both into one pointer > named reg. In rockchip_pinctrl_set_func(), two different offsets are > used with the same base address. The code erroneously uses > reg (base + offset) in place of base, leading to memory writes into > the wrong registers. Fix this. > > Signed-off-by: Ahmad Fatoum > --- > drivers/pinctrl/pinctrl-rockchip.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox