[PATCH] pinctrl: stm32: support deep probe

[PATCH] pinctrl: stm32: support deep probe

[Ahmad Fatoum]

The GPIO children of the pinctrl node don't have their own compatibles
and so the pinctrl driver probe takes care of the whole family.

GPIO drivers when deep probe is enabled don't like that because they
expect a driver to be associated with the GPIO device tree node, once
the chip was registered. Make them happy by assigning the dummy driver.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/pinctrl/pinctrl-stm32.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-stm32.c b/drivers/pinctrl/pinctrl-stm32.c
index 09b62309f6a1..97a643a4da67 100644
--- a/drivers/pinctrl/pinctrl-stm32.c
+++ b/drivers/pinctrl/pinctrl-stm32.c
@@ -412,11 +412,14 @@ static int stm32_pinctrl_probe(struct device_d *dev)
 		if (!of_property_read_bool(child, "gpio-controller"))
 			continue;
 
-		ret = stm32_gpiochip_add(gpio_bank++, child, dev);
+		ret = stm32_gpiochip_add(gpio_bank, child, dev);
 		if (ret) {
 			dev_err(dev, "couldn't add gpiochip %s, ret = %d\n", child->name, ret);
 			return ret;
 		}
+
+		of_platform_device_dummy_drv(gpio_bank->chip.dev);
+		gpio_bank++;
 	}
 
 	dev_dbg(dev, "pinctrl/gpio driver registered\n");
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] pinctrl: stm32: support deep probe

[Sascha Hauer]

On Mon, Jun 28, 2021 at 09:03:30AM +0200, Ahmad Fatoum wrote:
> The GPIO children of the pinctrl node don't have their own compatibles
> and so the pinctrl driver probe takes care of the whole family.
> 
> GPIO drivers when deep probe is enabled don't like that because they
> expect a driver to be associated with the GPIO device tree node, once
> the chip was registered. Make them happy by assigning the dummy driver.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/pinctrl/pinctrl-stm32.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox