From: Antony Pavlov <antonynpavlov@gmail.com> To: barebox@lists.infradead.org Cc: Ahmad Fatoum <a.fatoum@pengutronix.de> Subject: [PATCH 3/8] console: support set baudrate for fixed baudrate drivers Date: Tue, 17 Aug 2021 13:04:30 +0300 Message-ID: <20210817100435.114756-4-antonynpavlov@gmail.com> (raw) In-Reply-To: <20210817100435.114756-1-antonynpavlov@gmail.com> There are console drivers (linux, virtio, litex) that don't support baud rate setting and has no setbrg (set baudrate) callback, so console_set_baudrate() returns -ENOSYS. At the other hand console_set_baudrate() SUCCESS return value is needed for the loadx/loady commands correct work. See discussion here: http://lists.infradead.org/pipermail/barebox/2021-May/036237.html Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> --- common/console.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/common/console.c b/common/console.c index ad1a6aaab2..c902239e31 100644 --- a/common/console.c +++ b/common/console.c @@ -165,12 +165,12 @@ int console_set_baudrate(struct console_device *cdev, unsigned baudrate) int ret; unsigned char c; - if (!cdev->setbrg) - return -ENOSYS; - if (cdev->baudrate == baudrate) return 0; + if (!cdev->setbrg) + return -ENOSYS; + /* * If the device is already active, change its baudrate. * The baudrate of an inactive device will be set at activation time. @@ -336,11 +336,13 @@ int console_register(struct console_device *newcdev) ret = newcdev->setbrg(newcdev, baudrate); if (ret) return ret; - newcdev->baudrate_param = newcdev->baudrate = baudrate; + newcdev->baudrate_param = baudrate; dev_add_param_uint32(dev, "baudrate", console_baudrate_set, NULL, &newcdev->baudrate_param, "%u", newcdev); } + newcdev->baudrate = baudrate; + if (newcdev->putc && !newcdev->puts) newcdev->puts = __console_puts; -- 2.32.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-08-17 10:08 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-17 10:04 [PATCH 0/8 v4] RISC-V: add LiteX SoC support Antony Pavlov 2021-08-17 10:04 ` [PATCH 1/8] clocksource: timer-riscv: select CSR from device tree Antony Pavlov 2021-08-17 10:04 ` [PATCH 2/8] serial: add litex UART driver Antony Pavlov 2021-08-17 10:04 ` Antony Pavlov [this message] 2021-08-17 10:04 ` [PATCH 4/8] gpio: add driver for 74xx-ICs with MMIO access Antony Pavlov 2021-08-17 10:04 ` [PATCH 5/8] spi: add litex spiflash driver Antony Pavlov 2021-08-17 10:04 ` [PATCH 6/8] net: add LiteEth driver Antony Pavlov 2021-08-17 10:04 ` [PATCH 7/8] RISC-V: add LiteX SoC and linux-on-litex-vexriscv support Antony Pavlov 2021-08-17 10:04 ` [PATCH 8/8] RISC-V: add litex_linux_defconfig Antony Pavlov 2021-08-17 10:10 ` [PATCH 0/8 v4] RISC-V: add LiteX SoC support Antony Pavlov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210817100435.114756-4-antonynpavlov@gmail.com \ --to=antonynpavlov@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
mail archive of the barebox mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \ barebox@lists.infradead.org barebox@lists.infradead.org public-inbox-index barebox Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git