Re: [PATCH 2/4] common: add new menu for target tools

[Roland Hieber <rhi@pengutronix.de>]

On Tue, Sep 14, 2021 at 03:20:14PM +0200, Ahmad Fatoum wrote:
> We have four target tools and will add 3 more in a follow up commit.
> Add a new menu to collect them.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Looks very useful to me.

Acked-by: Roland Hieber <rhi@pengutronix.de>

> ---
>  common/Kconfig  | 26 --------------------------
>  scripts/Kconfig | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 26 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 222a438ee545..9dab7532e15e 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -734,18 +734,6 @@ config IMD
>  	select CRC32
>  	bool "barebox metadata support"
>  
> -config IMD_TARGET
> -	bool "build bareboximd target tool"
> -	depends on IMD
> -
> -config KERNEL_INSTALL_TARGET
> -	bool
> -	prompt "Build kernel-install utility for the target"
> -	help
> -	  Enable this to compile the kernel-install script using the cross
> -	  compiler. The utility for the target will be under
> -	  scripts/kernel-install-target
> -
>  choice
>  	prompt "console support"
>  	default CONSOLE_FULL
> @@ -980,20 +968,6 @@ config DEFAULT_ENVIRONMENT_PATH
>  	  be taken. Relative paths will be relative to the barebox top-level
>  	  directory, but absolute paths are fine as well.
>  
> -config BAREBOXENV_TARGET
> -	bool
> -	prompt "build bareboxenv tool for target"
> -	help
> -	  'bareboxenv' is a tool to access the barebox environment from a running Linux
> -	  system. Say yes here to build it for the target.
> -
> -config BAREBOXCRC32_TARGET
> -	bool
> -	prompt "build bareboxcrc32 tool for target"
> -	help
> -	  'bareboxcrc32' is a userspacetool to generate the crc32 checksums the same way
> -	  barebox does. Say yes here to build it for the target.
> -
>  config HAS_SCHED
>  	bool
>  
> diff --git a/scripts/Kconfig b/scripts/Kconfig
> index b903486ecd8f..f7ed775fbc66 100644
> --- a/scripts/Kconfig
> +++ b/scripts/Kconfig
> @@ -40,3 +40,33 @@ config OMAP4_HOSTTOOL_USBBOOT
>  	  You need libusb-1.0 to compile this tool.
>  
>  endmenu
> +
> +menu "Target Tools"
> +
> +config IMD_TARGET
> +	bool "build bareboximd target tool"
> +	depends on IMD
> +
> +config KERNEL_INSTALL_TARGET
> +	bool
> +	prompt "Build kernel-install utility for the target"
> +	help
> +	  Enable this to compile the kernel-install script using the cross
> +	  compiler. The utility for the target will be under
> +	  scripts/kernel-install-target
> +
> +config BAREBOXENV_TARGET
> +	bool
> +	prompt "build bareboxenv tool for target"
> +	help
> +	  'bareboxenv' is a tool to access the barebox environment from a running Linux
> +	  system. Say yes here to build it for the target.
> +
> +config BAREBOXCRC32_TARGET
> +	bool
> +	prompt "build bareboxcrc32 tool for target"
> +	help
> +	  'bareboxcrc32' is a userspacetool to generate the crc32 checksums the same way
> +	  barebox does. Say yes here to build it for the target.
> +
> +endmenu
> -- 
> 2.30.2
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox