From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 01 Oct 2021 15:30:23 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mWIcJ-0001Xh-Ii for lore@lore.pengutronix.de; Fri, 01 Oct 2021 15:30:23 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWIcI-000514-Ml for lore@pengutronix.de; Fri, 01 Oct 2021 15:30:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ny29MRgLnP8Vm6fmTIdNmYdAwDeegvVN5uJqr9i412o=; b=oap0ZG+/7YpEzxgHd9xTbkpotE MK9/XILhi82KHf1mIDuZCoME3s4xNWmUj6GaGZ5f0MUavce4CkU6nxUZEvGWCbQ3zbLYuiALgKk17 Tdx6JdgOfodxDFC3W6UWt0lC28cZgq+3ipGB1JFS1qugnTSm8PoSpK1nBpiEwCLN2T+AeWkHGxsXY hQMvpDx83j9j+K5zSFFctwVKHIj/gfg4YnPc39gTDhHFX6iX8P+jYetCkFi5h0sRslGxd5a0TlCnW 9D7++w6QOCYdQrd3l0w0aetZkXCjtGZ8GljS4sOdhFIL9mZGgO/g8AOgpei7+seX+k6BELRkOknG5 sEbBhIVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWIb9-000Qtt-89; Fri, 01 Oct 2021 13:29:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWIb4-000QtH-9n for barebox@lists.infradead.org; Fri, 01 Oct 2021 13:29:07 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWIb3-0004rn-29; Fri, 01 Oct 2021 15:29:05 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mWIb2-0006D7-PB; Fri, 01 Oct 2021 15:29:04 +0200 Date: Fri, 1 Oct 2021 15:29:04 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20211001132904.GW24834@pengutronix.de> References: <20210922071440.31949-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210922071440.31949-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:28:51 up 225 days, 16:52, 136 users, load average: 0.21, 0.15, 0.13 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_062906_360582_6C577F0D X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 1/2] startup: don't read glob_t if glob("/env/init/*") fails X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Wed, Sep 22, 2021 at 09:14:39AM +0200, Ahmad Fatoum wrote: > globfree() is a no-op if glob_t::gl_pathv is NULL. A failed glob may not > always initialize this member however, leading to potential memory > corruption. > > Fix this by only freeing the glob_t if glob() had succeeded. > > Signed-off-by: Ahmad Fatoum > --- > common/startup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox