From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 02 Oct 2021 11:36:41 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mWbRh-0003sA-T1 for lore@lore.pengutronix.de; Sat, 02 Oct 2021 11:36:41 +0200 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWbRh-0003Ue-1H for lore@pengutronix.de; Sat, 02 Oct 2021 11:36:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gK4W0f3RLK6O/OlYoLzH6D26DFtFxkp2jAGF/5DbI3c=; b=su6H1a/UZQPBFmrIKx/EJEokfV 0Cpi62KXUuuRJoGx2qEHhvRTiKejWXErWOY5U5y8+swAm4vQI6uqWZ0uc0Wwo+AodJqz3YQFJbPKX vJu8zauhQJXqrV2c/QRxAYEex1uEptSx+w9FT9OGehK+IOM3VOqAfuEMnIz64Xmfxvx+mC1K8uJnY oWtzxEsFAoIALyjZyc50K6HhtEVouYs+ca8r4fZeFS0C1AZYJ61lqkj5Qj5jdnbMLky25TcqukQBC kEGwxmtWZKRkcceDHPP8oaqy/FWLNpJeIvnr5+rRjlbskDooGBfB1E58n48hSI2aRZidTauSFiZZS ibuTaeSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWbQR-0020hG-1g; Sat, 02 Oct 2021 09:35:23 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWbQM-0020gu-Bd for barebox@lists.infradead.org; Sat, 02 Oct 2021 09:35:19 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWbQK-0003Gg-Ul; Sat, 02 Oct 2021 11:35:16 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mWbQK-00022l-IA; Sat, 02 Oct 2021 11:35:16 +0200 Date: Sat, 2 Oct 2021 11:35:16 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20211002093516.GK28453@pengutronix.de> References: <20210913101753.465831-1-ahmad@a3f.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210913101753.465831-1-ahmad@a3f.at> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:35:02 up 226 days, 12:58, 94 users, load average: 0.05, 0.10, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211002_023518_424973_40063B51 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:7c80:54:e::133 (failed) X-Broken-Reverse-DNS: no host name for IP address 2607:7c80:54:e::133 X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PTX_BROKEN_RDNS,RCVD_IN_DNSWL_MED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 Subject: Re: [PATCH master v2] base: driver: fix double removal of child devices X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Mon, Sep 13, 2021 at 12:17:53PM +0200, Ahmad Fatoum wrote: > Child devices like an ext4 file system on a partition may be removed > twice: Once because they're in the active devices list and then once > more, because unregister_device is called for the children of its parent. > > As struct bus_type::remove clears association of a driver with its > device, we can set struct device_d::driver to NULL. unregister_device > will then skip the second dev->bus->remove. > > Fixes: 29f1c211d86c ("fs: don't free device in remove callback") > Signed-off-by: Ahmad Fatoum > --- > v1 -> v2: > - remove left-over if condition line (Jules) > --- > drivers/base/driver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox