mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] net: cpsw: fix ethernet bringup in case of a fixed-link phy
@ 2021-08-31 12:57 Karfich, Oleg
  2021-10-04 11:07 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Karfich, Oleg @ 2021-08-31 12:57 UTC (permalink / raw)
  To: barebox; +Cc: Karfich, Oleg

In case of a fixed-link phy the cpsw_adjust_link() function is
called directly in phy_device_attach() and configures the MACCONTROL
register. Right after this configuration cpsw_init() is called and
resets the MACCONTROL register.
Fix this by initializing the slave before connecting the phy device in
cpsw_open().

Signed-off-by: Oleg Karfich <oleg.karfich@wago.com>
---
 drivers/net/cpsw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index b01e7ac..4a8f9e6 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -901,13 +901,13 @@ static int cpsw_open(struct eth_device *edev)
 
 	dev_dbg(&slave->dev, "* %s\n", __func__);
 
+	cpsw_slave_init(slave, priv);
+
 	ret = phy_device_connect(edev, NULL, slave->phy_id,
 				 cpsw_adjust_link, 0, slave->phy_if);
 	if (ret)
 		return ret;
 
-	cpsw_slave_init(slave, priv);
-
 	return 0;
 }
 
-- 
2.7.4

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: cpsw: fix ethernet bringup in case of a fixed-link phy
  2021-08-31 12:57 [PATCH] net: cpsw: fix ethernet bringup in case of a fixed-link phy Karfich, Oleg
@ 2021-10-04 11:07 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-10-04 11:07 UTC (permalink / raw)
  To: Karfich, Oleg; +Cc: barebox

On Tue, Aug 31, 2021 at 12:57:01PM +0000, Karfich, Oleg wrote:
> In case of a fixed-link phy the cpsw_adjust_link() function is
> called directly in phy_device_attach() and configures the MACCONTROL
> register. Right after this configuration cpsw_init() is called and
> resets the MACCONTROL register.
> Fix this by initializing the slave before connecting the phy device in
> cpsw_open().
> 
> Signed-off-by: Oleg Karfich <oleg.karfich@wago.com>
> ---
>  drivers/net/cpsw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
> index b01e7ac..4a8f9e6 100644
> --- a/drivers/net/cpsw.c
> +++ b/drivers/net/cpsw.c
> @@ -901,13 +901,13 @@ static int cpsw_open(struct eth_device *edev)
>  
>  	dev_dbg(&slave->dev, "* %s\n", __func__);
>  
> +	cpsw_slave_init(slave, priv);
> +
>  	ret = phy_device_connect(edev, NULL, slave->phy_id,
>  				 cpsw_adjust_link, 0, slave->phy_if);
>  	if (ret)
>  		return ret;
>  
> -	cpsw_slave_init(slave, priv);
> -
>  	return 0;
>  }
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-04 11:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 12:57 [PATCH] net: cpsw: fix ethernet bringup in case of a fixed-link phy Karfich, Oleg
2021-10-04 11:07 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git