From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: smc: disable -c (start cpu) test option for ARMv8
Date: Tue, 5 Oct 2021 13:52:17 +0200 [thread overview]
Message-ID: <20211005115217.GP28453@pengutronix.de> (raw)
In-Reply-To: <20211005113613.3609-1-a.fatoum@pengutronix.de>
On Tue, Oct 05, 2021 at 01:36:13PM +0200, Ahmad Fatoum wrote:
> This option is meant for debugging and was only tested on an ARMv7 CPU.
> On ARMv8, the handshake times out and the code executing on the second
> CPU invokes undefined behavior by modifying the stack base from a non-
> naked function. This led so far to a warning, which went unnoticed, but
> a follow-up commit will make it an error to use arm_setup_stack on
> ARM64. Prepare for this by disabling -c usage on ARM64.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Please reorder before "ARM: document arm_setup_stack() pitfalls"
> ---
> commands/smc.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-10-05 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 11:36 Ahmad Fatoum
2021-10-05 11:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005115217.GP28453@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox