mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] of: partitions: Skip fixup for devices with no partitions
@ 2021-10-11 19:19 Trent Piepho
  2021-10-12  7:47 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Trent Piepho @ 2021-10-11 19:19 UTC (permalink / raw)
  To: Barebox List; +Cc: Trent Piepho

If the device has no partitions, e.g. most EEPROM or OTP memory,
of_partition_fixup() can exit early, before trying to find the kernel dt
node and calling of_fixup_partitions().

This avoids spurious error messages when the kernel dt node doesn't
exist.  E.g., for an EEPROM in the Barebox dtb but not in the kernel
dtb, Barebox will display an error about being unable to fixup the
kernel dt node, however, if it had found the node it would just return
without doing anything since the partition list is empty, so really
there is no error.

Signed-off-by: Trent Piepho <trent.piepho@igorinstitute.com>
---
 drivers/of/partition.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/partition.c b/drivers/of/partition.c
index 10081363d..18b138f00 100644
--- a/drivers/of/partition.c
+++ b/drivers/of/partition.c
@@ -256,6 +256,9 @@ static int of_partition_fixup(struct device_node *root, void *ctx)
 	if (!cdev->device_node)
 		return -EINVAL;
 
+	if (list_empty(&cdev->partitions))
+		return 0;
+
 	name = of_get_reproducible_name(cdev->device_node);
 	np = of_find_node_by_reproducible_name(root, name);
 	free(name);
-- 
2.31.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] of: partitions: Skip fixup for devices with no partitions
  2021-10-11 19:19 [PATCH] of: partitions: Skip fixup for devices with no partitions Trent Piepho
@ 2021-10-12  7:47 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-10-12  7:47 UTC (permalink / raw)
  To: Trent Piepho; +Cc: Barebox List

On Mon, Oct 11, 2021 at 12:19:33PM -0700, Trent Piepho wrote:
> If the device has no partitions, e.g. most EEPROM or OTP memory,
> of_partition_fixup() can exit early, before trying to find the kernel dt
> node and calling of_fixup_partitions().
> 
> This avoids spurious error messages when the kernel dt node doesn't
> exist.  E.g., for an EEPROM in the Barebox dtb but not in the kernel
> dtb, Barebox will display an error about being unable to fixup the
> kernel dt node, however, if it had found the node it would just return
> without doing anything since the partition list is empty, so really
> there is no error.
> 
> Signed-off-by: Trent Piepho <trent.piepho@igorinstitute.com>
> ---
>  drivers/of/partition.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/of/partition.c b/drivers/of/partition.c
> index 10081363d..18b138f00 100644
> --- a/drivers/of/partition.c
> +++ b/drivers/of/partition.c
> @@ -256,6 +256,9 @@ static int of_partition_fixup(struct device_node *root, void *ctx)
>  	if (!cdev->device_node)
>  		return -EINVAL;
>  
> +	if (list_empty(&cdev->partitions))
> +		return 0;
> +
>  	name = of_get_reproducible_name(cdev->device_node);
>  	np = of_find_node_by_reproducible_name(root, name);
>  	free(name);
> -- 
> 2.31.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-12  7:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 19:19 [PATCH] of: partitions: Skip fixup for devices with no partitions Trent Piepho
2021-10-12  7:47 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git