From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] ARM: i.MX8M: nxp-imx8mn-evk: use regular i2c read for device detection
Date: Mon, 1 Nov 2021 10:10:13 +0100 [thread overview]
Message-ID: <20211101091013.GR25698@pengutronix.de> (raw)
In-Reply-To: <20211030141934.2207659-1-a.fatoum@pengutronix.de>
On Sat, Oct 30, 2021 at 04:19:34PM +0200, Ahmad Fatoum wrote:
> The barebox-nxp-imx8mn-evk image supports both DDR4 and LPDDR4 variants
> by probing for the PMIC in use as the former uses a BD71847 and the
> latter a PCA9450B.
>
> The PCA9450B was observed to hang on the 0-byte (probe) reads.
> This results in I/O errors during later PMIC writes and the image
> would only boot on the EVKs with DDR4, which have the other PMIC.
>
> Fix this by switching to a 1 byte read instead. Change tested on
> i.MX8MN DDR4 EVK as well as another board with LPDDR4.
>
> While at it, note the address of the PMIC in the error message, so it's
> clear, what the result of the i2c probe was.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/arm/boards/nxp-imx8mn-evk/lowlevel.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-11-01 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 14:19 Ahmad Fatoum
2021-11-01 9:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101091013.GR25698@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox