From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 10 Nov 2021 09:18:17 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mkioD-0004pH-NH for lore@lore.pengutronix.de; Wed, 10 Nov 2021 09:18:17 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkioC-0004j9-Nl for lore@pengutronix.de; Wed, 10 Nov 2021 09:18:17 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IMxi+4M5ths7gQviXl4q565swvJKsvnK3yKXMyUsUds=; b=Jv37u9VxbAP7AS sVSirZI/DGixWP1otOZUKHdcUcZd/NABVBFG9tOS9FjHfmAIhfrXRhqUg4IpMnPNs4P1OX6hUe2TL UrYgI062+8HuKNuNpiBeTGGzO8VzXTg5mq3xTjYGsMkc0mxO5Qidm9Etl6vEwwYJVPIwVQyedWUrS VGJDTx3Lu1JwQJ5x/2d+jjpl5mVCHFs6ucO4eu8iZ510pZ+AY/V+NhUaB4dsZdD0pBZCui0I1/Gg5 Rea+K8F26Wgn8+edsUHYMyrWFPE3z8zj9Z9NlPPEMur/5BLKhFw16nq1B2TqkAwuMrmwtWtzd6bZm b0RKQbD89jcs37DS8WVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkimO-004m49-UH; Wed, 10 Nov 2021 08:16:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkimJ-004m2u-UT for barebox@lists.infradead.org; Wed, 10 Nov 2021 08:16:21 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkimG-0004fh-1a; Wed, 10 Nov 2021 09:16:16 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mkimF-0006jF-DI; Wed, 10 Nov 2021 09:16:15 +0100 Date: Wed, 10 Nov 2021 09:16:15 +0100 From: Sascha Hauer To: Ahmad Fatoum Cc: Philipp Zabel , barebox@lists.infradead.org, Ian Abbott Message-ID: <20211110081615.GN25698@pengutronix.de> References: <20211101175207.2160779-1-a.fatoum@pengutronix.de> <20211102080651.GY25698@pengutronix.de> <401d5888-cfd6-4ef7-719b-e4878f7dbb2f@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <401d5888-cfd6-4ef7-719b-e4878f7dbb2f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:16:04 up 265 days, 11:39, 126 users, load average: 0.19, 0.29, 0.29 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_001620_013158_FF4C9554 X-CRM114-Status: GOOD ( 29.35 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master] mci: dw_mmc: make reset control optional again X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Mon, Nov 08, 2021 at 11:28:11AM +0100, Ahmad Fatoum wrote: > Hello Sascha, > > On 02.11.21 09:06, Sascha Hauer wrote: > > On Mon, Nov 01, 2021 at 06:52:07PM +0100, Ahmad Fatoum wrote: > >> As documented in 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC > >> compatibles"), it was intended for the reset to remain optional as to > >> not break existing users. Unfortunately, my later a3cf324593ea > >> ("mci: dw_mmc: add optional reset line") didn't heed that and made it > >> required, breaking SoCFPGA DW-MMC use as a result. > >> > >> Revert that line to fix the regression. > >> > >> Fixes: a3cf324593ea ("mci: dw_mmc: add optional reset line") > >> Reported-by: Ian Abbott > >> Signed-off-by: Ahmad Fatoum > >> --- > >> drivers/mci/dw_mmc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/mci/dw_mmc.c b/drivers/mci/dw_mmc.c > >> index b402090ab3cb..86c4f43e88f5 100644 > >> --- a/drivers/mci/dw_mmc.c > >> +++ b/drivers/mci/dw_mmc.c > >> @@ -572,7 +572,7 @@ static int dw_mmc_probe(struct device_d *dev) > >> > >> rst = reset_control_get(dev, "reset"); > > > > Philipp, the reset binding lists the reset-names property as optional. > > What's the expected behaviour of the reset_control_get() above when the > > reset-names property is not present in the device tree? Should it return > > an error or should it return the unnamed reset control? > > can this revert still be applied for master? I'll look into reworking this > for next. Did that. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox