From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 29 Nov 2021 09:05:57 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mrbfh-00043D-RH for lore@lore.pengutronix.de; Mon, 29 Nov 2021 09:05:57 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrbfh-00053m-00 for lore@pengutronix.de; Mon, 29 Nov 2021 09:05:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VE4s6JzKNeytqQ9mXHj3akWo5gQhajSvAgYBlnS0DHI=; b=o6gqMlbtXVHwvq 1DNoNr+Xx7Dfhuvjcri+32ih4o6DrwhHyZt2UOTK6hwB7Vs2YHvTUg/UBIJhtHIALctOmcxxmgnLP eAHbiGDlzjCLwuPBlBv6h35bHgKOJ/LAWqlfWk5rqE2nPLltJQalDHub7gmrX8IPixEVNQ51dqOIZ z/Zuk0wylc0t/Lht3i6wY7T4chDgdpIhhKR41H8dvku/7BS4XgLxmYzM+YuwlpKFKqMms+tZhXE+p xRiQ4dxF615+Enk+cyXW4KEK/SCXmXxIVTnuTL7iTJXla3Phy4XudH9EiMsZAJtRekWt7kcV+Guuv bHVSa4Wzcc1o0L71CVwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrbdz-0004KE-G1; Mon, 29 Nov 2021 08:04:11 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrbdu-0004Jv-NN for barebox@lists.infradead.org; Mon, 29 Nov 2021 08:04:08 +0000 Received: (Authenticated sender: ahmad@a3f.at) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8E82C1BF20A; Mon, 29 Nov 2021 08:04:02 +0000 (UTC) From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 29 Nov 2021 09:03:56 +0100 Message-Id: <20211129080356.2025369-1-ahmad@a3f.at> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_000406_933624_8E2FA082 X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] commands: devinfo: Omit parent if direct descendent of bus X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) In that case parentage adds no extra info, so we can just omit it. Signed-off-by: Ahmad Fatoum --- v1 -> v2: - add commands: prefix - check dev->bus before dereferencing it --- commands/devinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commands/devinfo.c b/commands/devinfo.c index 2e2e48e42cc5..32fd55ebd515 100644 --- a/commands/devinfo.c +++ b/commands/devinfo.c @@ -85,7 +85,7 @@ static int do_devinfo(int argc, char *argv[]) if (dev->info) dev->info(dev); - if (dev->parent) + if (dev->parent && (!dev->bus || dev->bus->dev != dev->parent)) printf("Parent: %s\n", dev_name(dev->parent)); first = true; -- 2.33.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox