From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] state: make first boot with uninitialized legacy state less verbose
Date: Tue, 30 Nov 2021 11:23:02 +0100 [thread overview]
Message-ID: <20211130102302.GP28260@pengutronix.de> (raw)
In-Reply-To: <20211129072235.2016324-1-ahmad@a3f.at>
On Mon, Nov 29, 2021 at 08:22:35AM +0100, Ahmad Fatoum wrote:
> With non-legacy state, barebox checks a header for a specific magic
> signature. This can be all zero on an uninitialized state, so in that
> particular case, bump down the log message severity.
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> Applies on top of https://lore.barebox.org/barebox/20211125161042.3829996-3-a.fatoum@pengutronix.de/
> ---
> common/state/backend_bucket_direct.c | 4 ++--
> common/state/backend_storage.c | 7 +++++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/common/state/backend_bucket_direct.c b/common/state/backend_bucket_direct.c
> index 517aec60634b..117cdfb46c9e 100644
> --- a/common/state/backend_bucket_direct.c
> +++ b/common/state/backend_bucket_direct.c
> @@ -76,9 +76,9 @@ static int state_backend_bucket_direct_read(struct state_backend_storage_bucket
> if (meta.magic != ~0 && !!meta.magic)
> bucket->wrong_magic = 1;
> if (!IS_ENABLED(CONFIG_STATE_BACKWARD_COMPATIBLE)) {
> - dev_err(direct->dev, "No meta data header found\n");
> dev_dbg(direct->dev, "Enable backward compatibility or increase stride size\n");
> - return -EINVAL;
> + return dev_err_state_init(direct->dev, meta.magic ? -EINVAL : -ENOMEDIUM,
> + "No meta data header found\n");
What is dev_err_state_init()? I don't have that in my tree.
> }
> read_len = direct->max_size;
> if (lseek(direct->fd, direct->offset, SEEK_SET) !=
> diff --git a/common/state/backend_storage.c b/common/state/backend_storage.c
> index 72f8bcf521ad..c55d22e37f70 100644
> --- a/common/state/backend_storage.c
> +++ b/common/state/backend_storage.c
> @@ -156,10 +156,13 @@ int state_storage_read(struct state_backend_storage *storage,
> totalbuckets++;
>
> ret = bucket->read(bucket, &bucket->buf, &bucket->len);
> - if (ret == -EUCLEAN)
> + if (ret == -EUCLEAN) {
> bucket->needs_refresh = 1;
> - else if (ret)
> + } else if (ret) {
> + if (ret == -ENOMEDIUM)
> + zerobuckets++;
This variable also does not exist. Does this patch depend on other
patches?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-11-30 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 7:22 Ahmad Fatoum
2021-11-30 10:23 ` Sascha Hauer [this message]
2021-11-30 10:39 ` Ahmad Fatoum
2022-01-03 10:27 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130102302.GP28260@pengutronix.de \
--to=sha@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--subject='Re: [PATCH] state: make first boot with uninitialized legacy state less verbose' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox