From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 02 Dec 2021 08:44:16 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1msglM-0006aY-Fe for lore@lore.pengutronix.de; Thu, 02 Dec 2021 08:44:16 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msglL-0002le-DE for lore@pengutronix.de; Thu, 02 Dec 2021 08:44:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=V7WAXhpxwznFXK0FsXVQyJZ93w9LGN86Lxtd8SdZnvs=; b=mSmpGdaUrBcaKw +PQdm/Yx+V25ABRE/YbVGiSqLsKUwZhADHZpXstUtIC8ORdGmNwe+htTy6/keUVCyEvqNdWYzfEoE fXHP2Igj2BDdw9XBfLEhBqUGJc1kSaheWaIoQjCnSxbJA/fe6EVTSmvoevLpL+PqQLMGYwSQ0hQho NZOWxHlDpZCVUkuhftMDczM2jD50dqfbLvoppi2vzYg9vI3Nb+oFXiwkCvh9dPm2sxTGBS6mIhjSm nVsx/LZqe09N/vagYTAr03aFxmC35+ekMviZ/EnwtJkwIRJJ06MY481xO9Qrkbf+1vXb11/yny4wM u+noDJ8W6Gh5iy0jgC/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msgjj-00BD6Y-CA; Thu, 02 Dec 2021 07:42:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msgje-00BD5V-P7 for barebox@lists.infradead.org; Thu, 02 Dec 2021 07:42:32 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msgja-0002Sk-1l; Thu, 02 Dec 2021 08:42:26 +0100 Received: from afa by dude.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1msgjZ-000oXq-Hd; Thu, 02 Dec 2021 08:42:25 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 2 Dec 2021 08:42:24 +0100 Message-Id: <20211202074224.193631-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_234230_859346_FBA8A38B X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] clk: bulk: improve error message on failure to get X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) We didn't have the need to handle %pOF specially yet, but for the error message in clk-bulk, not readily knowing what component couldn't get its clocks is annoying. Print the node name directly and change the error code to the error string if those are compiled in. Signed-off-by: Ahmad Fatoum --- drivers/clk/clk-bulk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index d530b4f968e6..4510283962ae 100644 --- a/drivers/clk/clk-bulk.c +++ b/drivers/clk/clk-bulk.c @@ -88,8 +88,8 @@ static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, clks[i].clk = of_clk_get(np, i); if (IS_ERR(clks[i].clk)) { ret = PTR_ERR(clks[i].clk); - pr_err("%pOF: Failed to get clk index: %d ret: %d\n", - np, i, ret); + pr_err("%s: Failed to get clk index: %d ret: %pe\n", + np->name, i, clks[i].clk); clks[i].clk = NULL; goto err; } -- 2.30.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox