mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] Revert "ARM: beaglebone: init MPU speed to 800Mhz"
Date: Tue, 7 Dec 2021 09:18:39 +0100	[thread overview]
Message-ID: <20211207081839.GD28260@pengutronix.de> (raw)
In-Reply-To: <20211203185154.388145-1-a.fatoum@pengutronix.de>

On Fri, Dec 03, 2021 at 07:51:54PM +0100, Ahmad Fatoum wrote:
> Commit 130c7d6715e9 ("ARM: beaglebone: init MPU speed to 800Mhz") causes
> warm reboot from within Linux v5.14.0 to no longer succeed.
> barebox MLO is entered, but hangs. Reset from within barebox is
> unaffected.
> This can be reproduced using DistroKit 949c5ef2b9a6 ("v7a: barebox:
> version bump v2021.08.0 → v2021.11.0") on a Beaglebone Black.
> Until that's figured out, revert the commit; functional reboot is more
> important than the quicker boot up.
> 
> This reverts commit 130c7d6715e932a1e0b3e026fea97f700ab33ea9.
> 
> Fixes: 130c7d6715e9 ("ARM: beaglebone: init MPU speed to 800Mhz")
> Reported-by: arwie # IRC
> Cc: Marc Reilly <marc@cpdesign.com.au>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/boards/beaglebone/lowlevel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/beaglebone/lowlevel.c b/arch/arm/boards/beaglebone/lowlevel.c
> index 31211448f5e8..91d143e4150b 100644
> --- a/arch/arm/boards/beaglebone/lowlevel.c
> +++ b/arch/arm/boards/beaglebone/lowlevel.c
> @@ -126,7 +126,7 @@ static noinline int beaglebone_sram_init(void)
>  
>  	/* Setup the PLLs and the clocks for the peripherals */
>  	if (is_beaglebone_black()) {
> -		am33xx_pll_init(MPUPLL_M_800, DDRPLL_M_400);
> +		am33xx_pll_init(MPUPLL_M_500, DDRPLL_M_400);
>  		am335x_sdram_init(0x18B, &ddr3_cmd_ctrl, &ddr3_regs,
>  				&ddr3_data);
>  	} else {
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2021-12-07  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 18:51 Ahmad Fatoum
2021-12-03 18:53 ` Ahmad Fatoum
2021-12-07  8:18 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211207081839.GD28260@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox