From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 09 Dec 2021 12:00:20 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mvH9w-0010lO-JM for lore@lore.pengutronix.de; Thu, 09 Dec 2021 12:00:20 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvH9u-0001Jr-PO for lore@pengutronix.de; Thu, 09 Dec 2021 12:00:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=APDCFecu20Xyj1Eui/hWS/ZWX622ow/1+GZ2hMBtsSM=; b=JxompLyuNM+Fs4 qQWIZsoXqywXJ2QAZ9EHeZIzBUvGoVCKcu3IwFLHBP/InacCCMz5OXvOWD+LTC8Yig/DAE7j3ikR+ ZoT8T1uvF7NqNEkay+yQDQbS9pYjuAPvYqVSa30CvB7+Lwt156/vW3xmb3Z9MKW+rVIA2QnNJCkDN ptP+63ZvvAEJ2+/IsWN9Qv+AyN7hb6kvd9Epucmr7NFhYKAWwawRBExGhoMY+G5VY6KR3Ob38092h FKIyk4on5Xcq0US6dI/3RgLjiP6YKg5SHYlD2LTiQ/Hy/zvL/P0UZqnEhe2L0e5uwd5rPlKC6ZSo3 Jcacns69/FtymD9+E8Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvH8l-00FhXk-26; Thu, 09 Dec 2021 10:59:07 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvH8O-00FhOD-7O for barebox@lists.infradead.org; Thu, 09 Dec 2021 10:58:45 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvH8N-0000mx-0c; Thu, 09 Dec 2021 11:58:43 +0100 Received: from afa by dude.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1mvH8M-00ElLA-Hg; Thu, 09 Dec 2021 11:58:42 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 9 Dec 2021 11:58:41 +0100 Message-Id: <20211209105841.3518522-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_025844_319209_401122CC X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] fixup! vsprintf: add optional support for %ls format modifier X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) -- has higher operator precedence than *, so instead of decreasing field_width, the pointer was decremented. This lead to misalignment, e.g. when doing of_dump. Fix this up. Signed-off-by: Ahmad Fatoum --- lib/vsprintf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index ce92787c58ef..9a94a1bbe84e 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -153,7 +153,7 @@ static char *leading_spaces(char *buf, const char *end, int len, int *field_width, int flags) { if (!(flags & LEFT)) { - while (len < *field_width--) { + while (len < (*field_width)--) { if (buf < end) *buf = ' '; ++buf; @@ -166,7 +166,7 @@ static char *leading_spaces(char *buf, const char *end, static char *trailing_spaces(char *buf, const char *end, int len, int *field_width, int flags) { - while (len < *field_width--) { + while (len < (*field_width)--) { if (buf < end) *buf = ' '; ++buf; -- 2.30.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox