mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 11/11] treewide: add SPDX-License-Identifier for files without explicit license
Date: Mon, 3 Jan 2022 17:50:39 +0100	[thread overview]
Message-ID: <20220103165039.p5cqln44got6ybrg@pengutronix.de> (raw)
In-Reply-To: <20220103122053.ry32inulqtx2wwsj@pengutronix.de>

On Mon, Jan 03, 2022 at 01:20:53PM +0100, Uwe Kleine-König wrote:
> On Mon, Jan 03, 2022 at 01:05:39PM +0100, Ahmad Fatoum wrote:
> > diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
> > index 04fef71d7be9..fcfc0ed192e1 100644
> > --- a/arch/arm/tools/gen-mach-types
> > +++ b/arch/arm/tools/gen-mach-types
> > @@ -1,5 +1,7 @@
> >  #!/bin/awk
> >  #
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
> 
> I would prefer to have the license identifier in the 2nd line. Not sure
> what the standard tells, but ISTR that in Linux the is no "empty" line,
> too.

I was stumbling over this one too, but the standard says "at or near the
top of the file" [1], so I think, this is okay.

Otherwise didn't notice anything strange while scrolling through this
series, except a few newline changes at ends of files here and there,
but I think those are okay too.

[1]: https://spdx.github.io/spdx-spec/using-SPDX-short-identifiers-in-source-files/#e2-format-for-spdx-license-identifier

> Otherwise thanks for your effort,

Yes, thank you!

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2022-01-03 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 12:05 [PATCH 00/11] treewide: SPDXify files without license statement Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 01/11] commands: set SPDX-License-Identifier for " Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 02/11] treewide: add SPDX-License-Identifier for Kbuild/Kconfig Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 03/11] treewide: add SPDX-License-Identifier for .gitignore Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 04/11] images: add SPDX-License-Identifiers Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 05/11] fs: jffs2: add SPDX-License-Identifier: GPL-2.0-only Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 06/11] include: add SPDX-License-Identifier Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 07/11] ARM: i.MX: add SPDX-License-Identifier for DCD Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 08/11] arch: add SPDX-License-Identifier to all headers Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 09/11] arch: add SPDX-License-Identifier to all .S files Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 10/11] arch: add SPDX-License-Identifier to all .c files Ahmad Fatoum
2022-01-03 12:05 ` [PATCH 11/11] treewide: add SPDX-License-Identifier for files without explicit license Ahmad Fatoum
2022-01-03 12:20   ` Uwe Kleine-König
2022-01-03 16:50     ` Roland Hieber [this message]
2022-01-05  8:00 ` [PATCH 00/11] treewide: SPDXify files without license statement Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220103165039.p5cqln44got6ybrg@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox