From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/3] driver: have CONFIG_DEBUG_PROBES report device unbind as well
Date: Sat, 8 Jan 2022 18:14:25 +0100 [thread overview]
Message-ID: <20220108171426.586330-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20220108171426.586330-1-a.fatoum@pengutronix.de>
This aligns it with DEBUG_INITCALLS, which also traces exitcalls.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/Kconfig | 10 ++++++++--
drivers/base/driver.c | 4 ++++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index d0055e2d2182..802bd9bfbb2e 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1503,9 +1503,15 @@ config DEBUG_INITCALLS
If enabled this will print initcall traces.
config DEBUG_PROBES
- bool "Trace driver probes"
+ bool "Trace driver probes/removes"
help
- If enabled this will print driver probe traces.
+ If enabled this will log driver probe and remove traces. If DEBUG_LL is enabled,
+ probes will be printed even before registering consoles. If it's disabled, they
+ will be collected in the log and written out once a console is active.
+
+ Removes are written to the log and will be printed as long as consoles exist.
+ Most consoles do not implement a remove callback to remain operable until
+ the very end. Consoles using DMA, however, must be removed.
config PBL_BREAK
bool "Execute software break on pbl start"
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index dd965eb165ee..bb07e96dcaf4 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -502,11 +502,15 @@ EXPORT_SYMBOL_GPL(dev_set_name);
static void devices_shutdown(void)
{
struct device_d *dev;
+ int depth = 0;
list_for_each_entry(dev, &active, active) {
if (dev->bus->remove) {
+ depth++;
+ pr_report_probe("%*sremove-> %s\n", depth * 4, "", dev_name(dev));
dev->bus->remove(dev);
dev->driver = NULL;
+ depth--;
}
}
}
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-01-08 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 17:14 [PATCH 1/3] tlsf: dump stack on assertion failure Ahmad Fatoum
2022-01-08 17:14 ` Ahmad Fatoum [this message]
2022-01-08 17:14 ` [PATCH 3/3] commands: add new devunbind debugging command Ahmad Fatoum
2022-01-10 8:56 ` Sascha Hauer
2022-01-13 16:04 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220108171426.586330-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox