From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 17 Jan 2022 23:21:51 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9aNr-004zIP-H9 for lore@lore.pengutronix.de; Mon, 17 Jan 2022 23:21:51 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9aNp-0005S0-Jx for lore@pengutronix.de; Mon, 17 Jan 2022 23:21:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gojAvSjod7DUnScel5rjksFYbvAxot1f7MQeh2nPV7w=; b=tgFkE4+Q0hAosw ed6yHQNUAyPdTJg3fCnV8Gg3AXexNjIHnHbMHztQzhwt1QOlyMSUwbFiKjVBwUqSdrrU7vze8fASV Ye1sA3ZftblNHMbPYh3s6PXx0OkHsHmvabLEJa4VD2wHtPgFB13Wm44apjr3KFqAn29DOLESItR4V lpIdBvNI0oBgXLz+C9cU+RXyJBXYQa2JqwM3gWpWU0g8Kbmj8Jzb/1skcms5y9WCF2JVhZVBN1SC6 wEyBN4Ap1c2NEqH9Xo0RebwRGdKCSiIXkhUY52VUOcrEmKHwYplAbWZ3//6HmLCRG1+6Tb2cEPmMj fSNJxoa1DYNRIaPEb+Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9aMI-00GTCL-EV; Mon, 17 Jan 2022 22:20:14 +0000 Received: from smtpout140.security-mail.net ([85.31.212.146] helo=fx601.security-mail.net) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9aM3-00GT6s-CE for barebox@lists.infradead.org; Mon, 17 Jan 2022 22:20:01 +0000 Received: from localhost (localhost [127.0.0.1]) by fx601.security-mail.net (Postfix) with ESMTP id 3397D3ACE38 for ; Mon, 17 Jan 2022 23:19:58 +0100 (CET) Received: from fx601 (localhost [127.0.0.1]) by fx601.security-mail.net (Postfix) with ESMTP id 8A18C3ACE24; Mon, 17 Jan 2022 23:19:56 +0100 (CET) X-Virus-Scanned: E-securemail Secumail-id: <5eb7.61e5eb8c.20668.0> Received: from zimbra2.kalray.eu (unknown [217.181.231.53]) by fx601.security-mail.net (Postfix) with ESMTPS id 218783ACD5A; Mon, 17 Jan 2022 23:19:56 +0100 (CET) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTPS id 0306527E03AE; Mon, 17 Jan 2022 23:19:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id DE15D27E040E; Mon, 17 Jan 2022 23:19:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu DE15D27E040E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalray.eu; s=32AE1B44-9502-11E5-BA35-3734643DEF29; t=1642457995; bh=07coFaaEd6CrvelCYOR5cjaMphMpnNGUZO/RsCl3BtI=; h=From:To:Date:Message-Id; b=nHqI5yuA64OaJHHefbxDUExADtlNRN0V5Mj3P+sA0UDBFrQfJrJ9GZoJKnx6WtNsw gQIXKlh5HaBShao5gb3ODYSmP0SnNyuYIDWkslQNZ9+z0b8o/JZNc6hzKjEe4mll6l 88x2R48mPdvNVI9I9elVwpwJcML2YdLQ+N4f3QzE= Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yPuJoPuDXjI4; Mon, 17 Jan 2022 23:19:55 +0100 (CET) Received: from tellis.lin.mbt.kalray.eu (unknown [192.168.36.206]) by zimbra2.kalray.eu (Postfix) with ESMTPSA id C8BF927E03CB; Mon, 17 Jan 2022 23:19:55 +0100 (CET) From: Jules Maselbas To: barebox@lists.infradead.org Cc: Clement Leger , Louis Morhet , Luc Michel , Yann Sionneau , Jules Maselbas Date: Mon, 17 Jan 2022 23:19:13 +0100 Message-Id: <20220117221917.26970-8-jmaselbas@kalray.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220117221917.26970-1-jmaselbas@kalray.eu> References: <20220117221917.26970-1-jmaselbas@kalray.eu> X-Virus-Scanned: by Secumail X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_141959_605045_C5EF8731 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 07/11] watchdog: kvx: do not disable watchdog on probe X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) From: Louis Morhet As the watchdog may be set by a lower stage in the boot chain, and for a good reason (precisely to ensure reliable update when something unexpected happens during the boot chain), it is a bad idea to always disable it during probe. We should either have a mechanism to refresh it on a regular basis in barebox itself and set it to something bigger for Linux, or handle it transparently and let the previous stage set the global watchdog up to Linux. This patch assumes for now the latter. Signed-off-by: Louis Morhet Signed-off-by: Jules Maselbas --- drivers/watchdog/kvx_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/kvx_wdt.c b/drivers/watchdog/kvx_wdt.c index da19136fda..df9430769b 100644 --- a/drivers/watchdog/kvx_wdt.c +++ b/drivers/watchdog/kvx_wdt.c @@ -73,11 +73,9 @@ static int kvx_wdt_drv_probe(struct device_d *dev) wdd->hwdev = dev; wdd->set_timeout = kvx_wdt_set_timeout; - /* Be sure that interrupt are disable */ + /* Be sure that interrupt are disabled */ kvx_sfr_set_field(TCR, WIE, 0); - kvx_watchdog_disable(); - return watchdog_register(wdd); } -- 2.17.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox