From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: deep-probe: replace BUG() with more verbose panic()
Date: Thu, 3 Mar 2022 11:05:50 +0100 [thread overview]
Message-ID: <20220303100550.GE19585@pengutronix.de> (raw)
In-Reply-To: <20220302200801.657501-1-ahmad@a3f.at>
On Wed, Mar 02, 2022 at 09:08:01PM +0100, Ahmad Fatoum wrote:
> In the case, we do hit this bug, the node name can be helpful, so
> print it out.
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> drivers/of/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 0e718469dbcd..9b487cbb0c68 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -422,7 +422,9 @@ int of_device_ensure_probed(struct device_node *np)
> if (IS_ERR(dev))
> return PTR_ERR(dev);
>
> - BUG_ON(!dev);
> + if (!dev)
> + panic("deep-probe: device for '%s' couldn't be created\n",
> + np->full_name);
>
> /*
> * The deep-probe mechanism relies on the fact that all necessary
> --
> 2.34.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-03-03 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 20:08 Ahmad Fatoum
2022-03-03 10:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303100550.GE19585@pengutronix.de \
--to=sha@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox