mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH next 2/2] fixup! clk: implement clk_hw_reparent
Date: Mon,  7 Mar 2022 18:02:10 +0100	[thread overview]
Message-ID: <20220307170210.3937726-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20220307170210.3937726-1-a.fatoum@pengutronix.de>

Revert "clk: implement clk_hw_reparent"

The implementation is faulty. In Linux, the function does accounting,
which seems not applicable to barebox and it does not do any hardware
access or set parentage, unlike the barebox port. As a previous commit
removed the sole use site of the helper to fix a bug, drop the helper
altogether.

This reverts commit 55a41677e2be90bbcaaa93cc541ead71a1e632d6.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Should result in an empty patch that can be skipped.
---
 include/linux/clk.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/linux/clk.h b/include/linux/clk.h
index ab96e36010c3..7fd835c35e51 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -241,14 +241,6 @@ int clk_hw_set_rate(struct clk_hw *hw, unsigned long rate);
 int clk_set_parent(struct clk *clk, struct clk *parent);
 int clk_hw_set_parent(struct clk_hw *hw, struct clk_hw *hwp);
 
-static inline void clk_hw_reparent(struct clk_hw *hw, struct clk_hw *new_parent)
-{
-	if (!hw)
-		return;
-
-	clk_hw_set_parent(hw, new_parent);
-}
-
 /**
  * clk_get_parent - get the parent clock source for this clock
  * @clk: clock source
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-03-07 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 17:02 [PATCH next 1/2] fixup! clk: stm32mp1: sync with Linux v5.17-rc1 Ahmad Fatoum
2022-03-07 17:02 ` Ahmad Fatoum [this message]
2022-03-08  8:20 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307170210.3937726-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox