From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 10 Mar 2022 10:35:13 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSFCR-000pE9-9w for lore@lore.pengutronix.de; Thu, 10 Mar 2022 10:35:13 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSFCP-0000UA-Lw for lore@pengutronix.de; Thu, 10 Mar 2022 10:35:10 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rcoeUmJzSqYFQNvTWn63F0ON/o3Max7qzUVse66meB0=; b=BzksAH61aETgv9bvIi63TCw0px /duQjLvwNgZ8c/GxIsfvyqC5S7W/ZcY144dZ1O4TbuEwxuiOA91hfSu/0dbubGK39A9GnB2Df0t/V MHn+zDhbqrOnNW/1ac2X5JAegOdIzQi8TjkDLClRlRtjgl7mCU0voNuhywr6R74r6tUlN9eGSlOWj SRANrfRkdowu2skqJsGSepyIBpdy3uRftsm85unnLS74JUj44z5BKtHsB5jc9BcqrVnDeTAUY54qh wduJ5wcDVDiYOsn727T6h6SQ4/+kJPKMqpryj+4fubmx33/TRSg2U556xob3/bIT7RYkGNpnqnroi n+OxW5Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSFAo-00C9mr-EP; Thu, 10 Mar 2022 09:33:30 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSFAj-00C9ls-M5 for barebox@lists.infradead.org; Thu, 10 Mar 2022 09:33:27 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSFAf-0000C9-Ir; Thu, 10 Mar 2022 10:33:21 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nSFAe-00027f-BX; Thu, 10 Mar 2022 10:33:20 +0100 Date: Thu, 10 Mar 2022 10:33:20 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org, Christian Melki , Jules Maselbas Message-ID: <20220310093320.GM22780@pengutronix.de> References: <20220304092805.1213879-1-ahmad@a3f.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220304092805.1213879-1-ahmad@a3f.at> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:32:27 up 89 days, 18:18, 86 users, load average: 0.15, 0.17, 0.18 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_013325_740608_572C7E9E X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] block: set S_IFBLK for block devices instead of S_IFCHR X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Fri, Mar 04, 2022 at 10:28:05AM +0100, Ahmad Fatoum wrote: > In barebox, block devices are a special case of character devices. > Nevertheless, differentiation can be useful to allow scripts iterating > over all block devices without accounting for naming, e.g. > > for dev in /dev/*; do > test -b $dev && echo $dev: blockdevice > done > > Add the necessary support. This will break scripts that assume > test -c blockdevice to be true, but that's a quite improbable check. > > Signed-off-by: Ahmad Fatoum > --- > commands/memtester/memtester.c | 2 +- > common/block.c | 8 ++++++++ > fs/devfs.c | 7 ++++++- > fs/legacy.c | 1 + > include/block.h | 2 ++ > 5 files changed, 18 insertions(+), 2 deletions(-) Dropped this patch. It breaks several defconfigs with: /home/sha/dude/barebox/barebox-maintainer-utils/barebox/fs/devfs.c:261: undefined reference to `cdev_get_block_device' Try for example a9m2410_defconfig Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox