From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] partitions: efi: print GPT offset in debug message
Date: Mon, 28 Mar 2022 10:54:53 +0200 [thread overview]
Message-ID: <20220328085453.GL12181@pengutronix.de> (raw)
In-Reply-To: <20220319072427.1310855-1-ahmad@a3f.at>
On Sat, Mar 19, 2022 at 08:24:27AM +0100, Ahmad Fatoum wrote:
> This debug message is printed for the alternative GPT header as well,
> which may not exist at that location, because the medium has a different
> length than what's in the GPT header. Make it easier to differentiate,
> whether the message refers to the primary or alternate GPT header by
> printing the LBA the header was expected at.
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> common/partitions/efi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/common/partitions/efi.c b/common/partitions/efi.c
> index 0787b93f120b..848bed22610f 100644
> --- a/common/partitions/efi.c
> +++ b/common/partitions/efi.c
> @@ -154,8 +154,8 @@ static int is_gpt_valid(struct block_device *blk, u64 lba,
>
> /* Check the GPT header signature */
> if (le64_to_cpu((*gpt)->signature) != GPT_HEADER_SIGNATURE) {
> - dev_dbg(blk->dev, "GUID Partition Table Header signature is wrong:"
> - "0x%llX != 0x%llX\n",
> + dev_dbg(blk->dev, "GUID Partition Table Header signature at LBA"
> + "%llu is wrong: 0x%llX != 0x%llX\n", lba,
> (unsigned long long)le64_to_cpu((*gpt)->signature),
> (unsigned long long)GPT_HEADER_SIGNATURE);
> goto fail;
> --
> 2.34.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-03-28 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 7:24 Ahmad Fatoum
2022-03-28 8:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328085453.GL12181@pengutronix.de \
--to=sha@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox