* [PATCH] ata: ide-sff: fix integer overflow in ata_wait_busy()
@ 2022-03-29 7:32 Denis Orlov
2022-04-01 13:01 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Denis Orlov @ 2022-03-29 7:32 UTC (permalink / raw)
To: barebox; +Cc: Denis Orlov
Signed-off-by: Denis Orlov <denorl2009@gmail.com>
---
drivers/ata/ide-sff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ide-sff.c b/drivers/ata/ide-sff.c
index 7884b62bab..69055e0585 100644
--- a/drivers/ata/ide-sff.c
+++ b/drivers/ata/ide-sff.c
@@ -96,7 +96,7 @@ static int ata_wait_busy(struct ide_port *ide, unsigned timeout)
{
uint8_t status;
uint64_t start = get_time_ns();
- uint64_t toffs = timeout * 1000 * 1000;
+ uint64_t toffs = timeout * MSECOND;
do {
status = ata_rd_status(ide);
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: ide-sff: fix integer overflow in ata_wait_busy()
2022-03-29 7:32 [PATCH] ata: ide-sff: fix integer overflow in ata_wait_busy() Denis Orlov
@ 2022-04-01 13:01 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-04-01 13:01 UTC (permalink / raw)
To: Denis Orlov; +Cc: barebox
On Tue, Mar 29, 2022 at 10:32:18AM +0300, Denis Orlov wrote:
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
> drivers/ata/ide-sff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/ata/ide-sff.c b/drivers/ata/ide-sff.c
> index 7884b62bab..69055e0585 100644
> --- a/drivers/ata/ide-sff.c
> +++ b/drivers/ata/ide-sff.c
> @@ -96,7 +96,7 @@ static int ata_wait_busy(struct ide_port *ide, unsigned timeout)
> {
> uint8_t status;
> uint64_t start = get_time_ns();
> - uint64_t toffs = timeout * 1000 * 1000;
> + uint64_t toffs = timeout * MSECOND;
>
> do {
> status = ata_rd_status(ide);
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-01 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29 7:32 [PATCH] ata: ide-sff: fix integer overflow in ata_wait_busy() Denis Orlov
2022-04-01 13:01 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox