mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: boards: Add support for MYIR MYD-AM335X Development Board
Date: Fri, 22 Apr 2022 08:50:50 +0200	[thread overview]
Message-ID: <20220422065050.GA4012@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvS4L7ZM7dYK+VZej56MdyMVXJiMVg3oLj2iYMVk9n0xcQ@mail.gmail.com>

On Thu, Apr 21, 2022 at 11:58:26AM +0300, Alexander Shiyan wrote:
> чт, 21 апр. 2022 г. в 11:30, Sascha Hauer <sha@pengutronix.de>:
> > On Thu, Apr 21, 2022 at 10:57:33AM +0300, Alexander Shiyan wrote:
> > > чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <sha@pengutronix.de>:
> > > >
> > > > On Wed, Apr 20, 2022 at 12:53:22PM +0300, Alexander Shiyan wrote:
> > > > > The MYD-AM335X Development Board designed by MYIR is a high-performance
> > > > > ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core
> > > > > controller board. It is based on up to 1GHz Texas Instruments (TI)
> > > > > Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver
> > > > > high DMIPs at a low cost while also delivering optional 3D graphics
> > > > > acceleration and key peripherals.
> > > > >
> > > > > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> > > ...
> > > > > +static struct omap_barebox_part myir_barebox_part = {
> > > > > +     .nand_offset = SZ_128K,
> > > > > +     .nand_size = SZ_512K,
> > > > > +};
> > > >
> > > > Isn't this a bit too small? Putting a barebox into 128k seems very
> > > > ambicous.
> > >
> > > The boot image (MLO) should not exceed 128 KB in size,
> > > so I think this should be enough.
> > > In any case this size is already specified for the boot partition
> > > in kernel DTS for this board. :)
> >
> > Oh, I accidently misread nand_size as SZ_128K. Indeed it's SZ_512K which
> > is small, but sufficient. Anyway, the BBU code assumes 4 eraseblocks for
> > the four MLO images. That would be a nand_offset of SZ_512K also, which
> > would then also match the upstream device tree for the board:
> >
> > &nand0 {
> >         partition@0 {
> >                 label = "MLO";
> >                 reg = <0x00000 0x20000>;
> >         };
> >
> >         partition@20000 {
> >                 label = "boot";
> >                 reg = <0x20000 0x80000>;
> >         };
> > };
> >
> > 512k is still very small nowadays. The images built with omap_defconfig
> > are just a bit smaller than that.
> 
> Do you prefer that we fix this in the local overlay now,
> or leave it as is until kernel DTS upstream changes?

Do it locally for now. BTW you used a legacy binding here. Nowadays the
partitions are under a partitions node with compatible
"fixed-partitions".

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2022-04-22  6:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  9:53 Alexander Shiyan
2022-04-21  7:35 ` Sascha Hauer
2022-04-21  7:57   ` Alexander Shiyan
2022-04-21  8:30     ` Sascha Hauer
2022-04-21  8:58       ` Alexander Shiyan
2022-04-22  6:50         ` Sascha Hauer [this message]
2022-04-22  7:25           ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422065050.GA4012@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox