From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] serial: ns16550: Reuse 16550 serial for tegra UART
Date: Mon, 25 Apr 2022 12:27:41 +0200 [thread overview]
Message-ID: <20220425102741.GI4012@pengutronix.de> (raw)
In-Reply-To: <20220422092155.41183-1-eagle.alexander923@gmail.com>
On Fri, Apr 22, 2022 at 12:21:55PM +0300, Alexander Shiyan wrote:
> The initialization for the tegra UART is the same as for the standard 16550,
> so there is no reason to keep a separate structure for it in the driver.
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> drivers/serial/serial_ns16550.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 464ae1aebc..f93a89ab95 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -366,11 +366,6 @@ static __maybe_unused struct ns16550_drvdata jz_drvdata = {
> .init_port = ns16550_jz_init_port,
> };
>
> -static __maybe_unused struct ns16550_drvdata tegra_drvdata = {
> - .init_port = ns16550_serial_init_port,
> - .linux_console_name = "ttyS",
> -};
> -
> static __maybe_unused struct ns16550_drvdata rpi_drvdata = {
> .init_port = rpi_init_port,
> .linux_console_name = "ttyS",
> @@ -528,6 +523,9 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
> }, {
> .compatible = "marvell,armada-38x-uart",
> .data = &ns16550_drvdata,
> + }, {
> + .compatible = "nvidia,tegra20-uart",
> + .data = &ns16550_drvdata,
> },
> #if IS_ENABLED(CONFIG_ARCH_OMAP)
> {
> @@ -541,12 +539,6 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
> .data = &omap_drvdata,
> },
> #endif
> -#if IS_ENABLED(CONFIG_ARCH_TEGRA)
> - {
> - .compatible = "nvidia,tegra20-uart",
> - .data = &tegra_drvdata,
> - },
> -#endif
> #if IS_ENABLED(CONFIG_MACH_MIPS_XBURST)
> {
> .compatible = "ingenic,jz4740-uart",
> --
> 2.32.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-04-25 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 9:21 Alexander Shiyan
2022-04-25 10:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425102741.GI4012@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox