mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] mci: stm32_sdmmc2: add STM32MP131 AMBA primecell peripheral ID
@ 2022-04-26 14:15 Ahmad Fatoum
  2022-04-29  7:16 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-04-26 14:15 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

v5.18-rc1 device tree now features different peripheral ID. As
peripheral IDs have no fallbacks, this meant broken SD on STM32MP131.

Add new peripheral ID without special handling as IP is
backwards-compatible. DT also contains a st,stm32-sdmmc2 compatible,
which we could match against in future, but for now this isn't
necessary.

Fixes: b01786baa849 ("dts: update to v5.18-rc1")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/stm32_sdmmc2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
index 0c620427ee44..40ffc17908b2 100644
--- a/drivers/mci/stm32_sdmmc2.c
+++ b/drivers/mci/stm32_sdmmc2.c
@@ -643,6 +643,11 @@ static struct amba_id stm32_sdmmc2_ids[] = {
 		.id     = 0x00253180,
 		.mask	= 0xf0ffffff,
 	},
+	/* ST Micro STM32MP13 */
+	{
+		.id     = 0x20253180,
+		.mask	= 0xf0ffffff,
+	},
 	{ 0, 0 },
 };
 
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] mci: stm32_sdmmc2: add STM32MP131 AMBA primecell peripheral ID
  2022-04-26 14:15 [PATCH master] mci: stm32_sdmmc2: add STM32MP131 AMBA primecell peripheral ID Ahmad Fatoum
@ 2022-04-29  7:16 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-04-29  7:16 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Tue, Apr 26, 2022 at 04:15:04PM +0200, Ahmad Fatoum wrote:
> v5.18-rc1 device tree now features different peripheral ID. As
> peripheral IDs have no fallbacks, this meant broken SD on STM32MP131.
> 
> Add new peripheral ID without special handling as IP is
> backwards-compatible. DT also contains a st,stm32-sdmmc2 compatible,
> which we could match against in future, but for now this isn't
> necessary.
> 
> Fixes: b01786baa849 ("dts: update to v5.18-rc1")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mci/stm32_sdmmc2.c | 5 +++++
>  1 file changed, 5 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c
> index 0c620427ee44..40ffc17908b2 100644
> --- a/drivers/mci/stm32_sdmmc2.c
> +++ b/drivers/mci/stm32_sdmmc2.c
> @@ -643,6 +643,11 @@ static struct amba_id stm32_sdmmc2_ids[] = {
>  		.id     = 0x00253180,
>  		.mask	= 0xf0ffffff,
>  	},
> +	/* ST Micro STM32MP13 */
> +	{
> +		.id     = 0x20253180,
> +		.mask	= 0xf0ffffff,
> +	},
>  	{ 0, 0 },
>  };
>  
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-29  7:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 14:15 [PATCH master] mci: stm32_sdmmc2: add STM32MP131 AMBA primecell peripheral ID Ahmad Fatoum
2022-04-29  7:16 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git