mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <>
Cc:, Ahmad Fatoum <>
Subject: [PATCH] fastboot: inform user if barebox update falls back to raw copy
Date: Tue, 31 May 2022 11:35:37 +0200	[thread overview]
Message-ID: <> (raw)

Fastboot code determines whether to go into barebox update handler by
checking whether filetype_is_barebox_image() returns true for the image.
This is different from the barebox_update command which leaves it to the
individual handlers to decide whether an image is suitable.

Coupled with eMMC boot partitions, this could lead to
`barebox_update -t mmc` updating the boot partition, while a
`fastboot flash bbu-mmc` will write the image to the user area instead.

It may be worth breaking backwards compatibility here and refuse update
in that case, but for now at least alert the user that a raw copy is
being attempted.

Signed-off-by: Ahmad Fatoum <>
 common/fastboot.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/common/fastboot.c b/common/fastboot.c
index f8ed40c86e00..50ea8421d92c 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -673,7 +673,7 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
 		goto out;
-	if (IS_ENABLED(CONFIG_BAREBOX_UPDATE) && filetype_is_barebox_image(filetype)) {
 		void *buf;
 		struct bbu_handler *handler;
 		struct bbu_data data = {
@@ -681,6 +681,17 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
 			.flags = BBU_FLAG_YES,
+		if (!filetype_is_barebox_image(filetype)) {
+			if (strstarts(fentry->name, "bbu-")) {
+				fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
+						  "This is _not_ a barebox image...");
+				fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
+						  "Falling back to raw copy to %s", filename);
+			}
+			goto copy;
+		}
 		handler = bbu_find_handler_by_device(data.devicefile);
 		if (!handler)
 			goto copy;

barebox mailing list

             reply	other threads:[~2022-05-31  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  9:35 Ahmad Fatoum [this message]
2022-06-09  6:05 ` Ahmad Fatoum
2022-06-09  7:19 ` Sascha Hauer
2022-06-09  8:21   ` Ahmad Fatoum
2022-06-09  8:33     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox