mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 0/5] Misc fixes
@ 2022-06-01  6:02 Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 1/5] ARM: at91sam9n12ek: Use xz compression Alexander Shiyan
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

Unsorted various fixes for the barebox.

Alexander Shiyan (5):
  ARM: at91sam9n12ek: Use xz compression
  ARM: boards: Fix unconditional compilation of imx51-babbage directory
  drivers: soc: Fix unconditional compilation of imx directory
  globalvar: Add missing empty prototype for globalvar_set()
  of: Fix of_prepend_machine_compatible() defined but unused warning

 arch/arm/boards/Makefile                 | 2 +-
 arch/arm/configs/at91sam9n12ek_defconfig | 5 +----
 drivers/soc/Makefile                     | 4 ++--
 include/globalvar.h                      | 2 ++
 include/of.h                             | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/5] ARM: at91sam9n12ek: Use xz compression
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
@ 2022-06-01  6:02 ` Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory Alexander Shiyan
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

The binary created with at91sam9n12ek_defconfig got too big over time.
Use xz compression to match the bounds.

CHKFILESIZE images/start_pbl.pblb
images/start_pbl.pblb size 270996 > maximum size 262144

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 arch/arm/configs/at91sam9n12ek_defconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/configs/at91sam9n12ek_defconfig b/arch/arm/configs/at91sam9n12ek_defconfig
index b7c3a4b1f4..ce97ad62dc 100644
--- a/arch/arm/configs/at91sam9n12ek_defconfig
+++ b/arch/arm/configs/at91sam9n12ek_defconfig
@@ -4,12 +4,12 @@ CONFIG_BAREBOX_MAX_IMAGE_SIZE=0x40000
 CONFIG_AEABI=y
 CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
 CONFIG_PBL_IMAGE=y
+CONFIG_IMAGE_COMPRESSION_XZKERN=y
 CONFIG_MMU=y
 CONFIG_MALLOC_SIZE=0xa00000
 CONFIG_EXPERIMENTAL=y
 CONFIG_MALLOC_TLSF=y
 CONFIG_PROMPT="9G20-EK:"
-CONFIG_GLOB=y
 CONFIG_PROMPT_HUSH_PS2="y"
 CONFIG_HUSH_FANCY_PROMPT=y
 CONFIG_CMDLINE_EDITING=y
@@ -60,9 +60,6 @@ CONFIG_MTD=y
 # CONFIG_MTD_OOB_DEVICE is not set
 CONFIG_MTD_M25P80=y
 CONFIG_NAND=y
-# CONFIG_NAND_ECC_SOFT is not set
-# CONFIG_NAND_ECC_HW_SYNDROME is not set
-# CONFIG_NAND_ECC_HW_NONE is not set
 CONFIG_NAND_ATMEL=y
 CONFIG_NAND_ATMEL_PMECC=y
 CONFIG_USB_GADGET=y
-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 1/5] ARM: at91sam9n12ek: Use xz compression Alexander Shiyan
@ 2022-06-01  6:02 ` Alexander Shiyan
  2022-06-02  6:47   ` Sascha Hauer
  2022-06-01  6:02 ` [PATCH 3/5] drivers: soc: Fix unconditional compilation of imx directory Alexander Shiyan
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 arch/arm/boards/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
index d303999614..042b27a804 100644
--- a/arch/arm/boards/Makefile
+++ b/arch/arm/boards/Makefile
@@ -47,7 +47,7 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD)		+= eukrea_cpuimx51/
 obj-$(CONFIG_MACH_ELTEC_HIPERCAM)		+= eltec-hipercam/
 obj-$(CONFIG_MACH_FREESCALE_MX25_3STACK)	+= freescale-mx25-3ds/
 obj-$(CONFIG_MACH_FREESCALE_MX35_3STACK)	+= freescale-mx35-3ds/
-obj-y						+= freescale-mx51-babbage/
+obj-$(CONFIG_MACH_FREESCALE_MX51_PDK)		+= freescale-mx51-babbage/
 obj-$(CONFIG_MACH_FREESCALE_MX53_LOCO)		+= freescale-mx53-qsb/
 obj-$(CONFIG_MACH_FREESCALE_MX53_SMD)		+= freescale-mx53-smd/
 obj-$(CONFIG_MACH_FREESCALE_MX53_VMX53)		+= freescale-mx53-vmx53/
-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/5] drivers: soc: Fix unconditional compilation of imx directory
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 1/5] ARM: at91sam9n12ek: Use xz compression Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory Alexander Shiyan
@ 2022-06-01  6:02 ` Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 4/5] globalvar: Add missing empty prototype for globalvar_set() Alexander Shiyan
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

As a side change, this patch sorts entries alphabetically.

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 drivers/soc/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
index e5b319e6da..a23e81ffb3 100644
--- a/drivers/soc/Makefile
+++ b/drivers/soc/Makefile
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
-obj-y	+= imx/
+obj-$(CONFIG_ARCH_IMX)		+= imx/
+obj-$(CONFIG_KVX)		+= kvx/
 obj-$(CONFIG_CPU_SIFIVE)	+= sifive/
 obj-$(CONFIG_SOC_STARFIVE)	+= starfive/
-obj-$(CONFIG_KVX)	+= kvx/
-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4/5] globalvar: Add missing empty prototype for globalvar_set()
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
                   ` (2 preceding siblings ...)
  2022-06-01  6:02 ` [PATCH 3/5] drivers: soc: Fix unconditional compilation of imx directory Alexander Shiyan
@ 2022-06-01  6:02 ` Alexander Shiyan
  2022-06-01  6:02 ` [PATCH 5/5] of: Fix of_prepend_machine_compatible() defined but unused warning Alexander Shiyan
  2022-06-02  6:54 ` [PATCH 0/5] Misc fixes Sascha Hauer
  5 siblings, 0 replies; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

common/fastboot.c: In function 'cb_boot':
common/fastboot.c:396:2: error: implicit declaration of function 'globalvar_set'
globalvar_set("bootm.image", "");

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 include/globalvar.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/globalvar.h b/include/globalvar.h
index 476bb920f3..ff1da6c927 100644
--- a/include/globalvar.h
+++ b/include/globalvar.h
@@ -101,6 +101,8 @@ static inline char *globalvar_get_match(const char *match, const char *separator
 
 static inline void globalvar_set_match(const char *match, const char *val) {}
 
+static inline void globalvar_set(const char *name, const char *val) {}
+
 static inline int nvvar_load(void)
 {
 	return 0;
-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 5/5] of: Fix of_prepend_machine_compatible() defined but unused warning
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
                   ` (3 preceding siblings ...)
  2022-06-01  6:02 ` [PATCH 4/5] globalvar: Add missing empty prototype for globalvar_set() Alexander Shiyan
@ 2022-06-01  6:02 ` Alexander Shiyan
  2022-06-02  6:54 ` [PATCH 0/5] Misc fixes Sascha Hauer
  5 siblings, 0 replies; 9+ messages in thread
From: Alexander Shiyan @ 2022-06-01  6:02 UTC (permalink / raw)
  To: barebox; +Cc: Alexander Shiyan

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 include/of.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/of.h b/include/of.h
index 3a8e32f69c..46b96277d5 100644
--- a/include/of.h
+++ b/include/of.h
@@ -835,7 +835,7 @@ static inline int of_autoenable_i2c_by_component(char *path)
 	return -ENODEV;
 }
 
-static int of_prepend_machine_compatible(struct device_node *root,
+static inline int of_prepend_machine_compatible(struct device_node *root,
 					 const char *compat)
 {
 	return -ENODEV;
-- 
2.32.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory
  2022-06-01  6:02 ` [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory Alexander Shiyan
@ 2022-06-02  6:47   ` Sascha Hauer
  2022-06-02  6:51     ` Ahmad Fatoum
  0 siblings, 1 reply; 9+ messages in thread
From: Sascha Hauer @ 2022-06-02  6:47 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

On Wed, Jun 01, 2022 at 09:02:23AM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
>  arch/arm/boards/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
> index d303999614..042b27a804 100644
> --- a/arch/arm/boards/Makefile
> +++ b/arch/arm/boards/Makefile
> @@ -47,7 +47,7 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD)		+= eukrea_cpuimx51/
>  obj-$(CONFIG_MACH_ELTEC_HIPERCAM)		+= eltec-hipercam/
>  obj-$(CONFIG_MACH_FREESCALE_MX25_3STACK)	+= freescale-mx25-3ds/
>  obj-$(CONFIG_MACH_FREESCALE_MX35_3STACK)	+= freescale-mx35-3ds/
> -obj-y						+= freescale-mx51-babbage/
> +obj-$(CONFIG_MACH_FREESCALE_MX51_PDK)		+= freescale-mx51-babbage/

This change was intentional. The board code exports imx51_babbage_power_init()
which is used by the zii-imx51-rdu1 board code as well.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory
  2022-06-02  6:47   ` Sascha Hauer
@ 2022-06-02  6:51     ` Ahmad Fatoum
  0 siblings, 0 replies; 9+ messages in thread
From: Ahmad Fatoum @ 2022-06-02  6:51 UTC (permalink / raw)
  To: Sascha Hauer, Alexander Shiyan; +Cc: barebox

On 02.06.22 08:47, Sascha Hauer wrote:
> On Wed, Jun 01, 2022 at 09:02:23AM +0300, Alexander Shiyan wrote:
>> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
>> ---
>>  arch/arm/boards/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
>> index d303999614..042b27a804 100644
>> --- a/arch/arm/boards/Makefile
>> +++ b/arch/arm/boards/Makefile
>> @@ -47,7 +47,7 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD)		+= eukrea_cpuimx51/
>>  obj-$(CONFIG_MACH_ELTEC_HIPERCAM)		+= eltec-hipercam/
>>  obj-$(CONFIG_MACH_FREESCALE_MX25_3STACK)	+= freescale-mx25-3ds/
>>  obj-$(CONFIG_MACH_FREESCALE_MX35_3STACK)	+= freescale-mx35-3ds/
>> -obj-y						+= freescale-mx51-babbage/
>> +obj-$(CONFIG_MACH_FREESCALE_MX51_PDK)		+= freescale-mx51-babbage/
> 
> This change was intentional. The board code exports imx51_babbage_power_init()
> which is used by the zii-imx51-rdu1 board code as well.

FWIW, we have added common/boards/ since then, which can be used for
such functions.

Cheers,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/5] Misc fixes
  2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
                   ` (4 preceding siblings ...)
  2022-06-01  6:02 ` [PATCH 5/5] of: Fix of_prepend_machine_compatible() defined but unused warning Alexander Shiyan
@ 2022-06-02  6:54 ` Sascha Hauer
  5 siblings, 0 replies; 9+ messages in thread
From: Sascha Hauer @ 2022-06-02  6:54 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

On Wed, Jun 01, 2022 at 09:02:21AM +0300, Alexander Shiyan wrote:
> Unsorted various fixes for the barebox.
> 
> Alexander Shiyan (5):
>   ARM: at91sam9n12ek: Use xz compression
>   ARM: boards: Fix unconditional compilation of imx51-babbage directory
>   drivers: soc: Fix unconditional compilation of imx directory
>   globalvar: Add missing empty prototype for globalvar_set()
>   of: Fix of_prepend_machine_compatible() defined but unused warning

Applied 1 and 3-5, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-06-02  6:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01  6:02 [PATCH 0/5] Misc fixes Alexander Shiyan
2022-06-01  6:02 ` [PATCH 1/5] ARM: at91sam9n12ek: Use xz compression Alexander Shiyan
2022-06-01  6:02 ` [PATCH 2/5] ARM: boards: Fix unconditional compilation of imx51-babbage directory Alexander Shiyan
2022-06-02  6:47   ` Sascha Hauer
2022-06-02  6:51     ` Ahmad Fatoum
2022-06-01  6:02 ` [PATCH 3/5] drivers: soc: Fix unconditional compilation of imx directory Alexander Shiyan
2022-06-01  6:02 ` [PATCH 4/5] globalvar: Add missing empty prototype for globalvar_set() Alexander Shiyan
2022-06-01  6:02 ` [PATCH 5/5] of: Fix of_prepend_machine_compatible() defined but unused warning Alexander Shiyan
2022-06-02  6:54 ` [PATCH 0/5] Misc fixes Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox