From: Alexander Shiyan <eagle.alexander923@gmail.com> To: barebox@lists.infradead.org Cc: Alexander Shiyan <eagle.alexander923@gmail.com> Subject: [PATCH] ARM: OMAP: syslib: Optimize wait_on_value() function Date: Mon, 6 Jun 2022 09:40:34 +0300 [thread overview] Message-ID: <20220606064034.9568-1-eagle.alexander923@gmail.com> (raw) Saves up to 8 bytes in THUMB mode. Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> --- arch/arm/mach-omap/syslib.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-omap/syslib.c b/arch/arm/mach-omap/syslib.c index 42da348c5a..488f0ab859 100644 --- a/arch/arm/mach-omap/syslib.c +++ b/arch/arm/mach-omap/syslib.c @@ -52,19 +52,16 @@ void sdelay(unsigned long loops) * @param[in] read_addr address to read from * @param[in] bound max iterations * - * @return 1 if match_value is found, else if bound iterations reached, + * @return non zero if match_value is found, else if bound iterations reached, * returns 0 */ u32 wait_on_value(u32 read_bit_mask, u32 match_value, u32 read_addr, u32 bound) { - u32 i = 0, val; do { - ++i; - val = readl(read_addr) & read_bit_mask; + u32 val = readl(read_addr) & read_bit_mask; if (val == match_value) - return 1; - if (i == bound) - return 0; - } while (1); -} + break; + } while (--bound); + return bound; +} -- 2.32.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2022-06-06 6:42 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-06 6:40 Alexander Shiyan [this message] 2022-06-07 7:17 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220606064034.9568-1-eagle.alexander923@gmail.com \ --to=eagle.alexander923@gmail.com \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH] ARM: OMAP: syslib: Optimize wait_on_value() function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox