From: Sascha Hauer <sha@pengutronix.de> To: Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: barebox@lists.infradead.org Subject: Re: [PATCH v2 2/2] fastboot: inform user if barebox update falls back to raw copy Date: Thu, 9 Jun 2022 13:40:01 +0200 [thread overview] Message-ID: <20220609114001.GR1615@pengutronix.de> (raw) In-Reply-To: <20220609111703.2446899-2-a.fatoum@pengutronix.de> On Thu, Jun 09, 2022 at 01:17:03PM +0200, Ahmad Fatoum wrote: > Fastboot will fall back to a raw copy even for bbu- partitions if > no barebox_update was found or if support isn't compiled in. > > Coupled with eMMC boot partitions, this could lead to > `barebox_update -t mmc` updating the boot partition, while a > `fastboot flash bbu-mmc` will write the image to the user area instead. Have you seen this happen? > > It's worth telling the user when this happens, so add a status message. when a eMMC boot partition is registered for barebox update then the update should really go there. When it goes into the user area instead it's a bug. We shouldn't issue a warning then but deny the update and fix the underlying bug. Sascha > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- > v1 -> v2: > - print message in case barebox_update handler is not found > --- > common/fastboot.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/common/fastboot.c b/common/fastboot.c > index 330a06f5a32f..24eddf1cc3a5 100644 > --- a/common/fastboot.c > +++ b/common/fastboot.c > @@ -683,8 +683,14 @@ static void cb_flash(struct fastboot *fb, const char *cmd) > }; > > handler = bbu_find_handler_by_device(data.devicefile); > - if (!handler) > + if (!handler) { > + fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > + "No suitable barebox_update handler found"); > + fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > + "Falling back to raw copy to %s", filename); > + > goto copy; > + } > > fastboot_tx_print(fb, FASTBOOT_MSG_INFO, > "This is a barebox image..."); > -- > 2.30.2 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-06-09 11:49 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-09 11:17 [PATCH v2 1/2] fastboot: always try barebox_update handler for bbu- partitions Ahmad Fatoum 2022-06-09 11:17 ` [PATCH v2 2/2] fastboot: inform user if barebox update falls back to raw copy Ahmad Fatoum 2022-06-09 11:40 ` Sascha Hauer [this message] 2022-06-09 12:02 ` Ahmad Fatoum 2022-06-09 13:02 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220609114001.GR1615@pengutronix.de \ --to=sha@pengutronix.de \ --cc=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH v2 2/2] fastboot: inform user if barebox update falls back to raw copy' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox