From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: Michael Riesch <michael.riesch@wolfvision.net>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] common: reset_source: Remove of_get_reset_source_priority()
Date: Fri, 10 Jun 2022 09:32:32 +0200 [thread overview]
Message-ID: <20220610073232.GB1615@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvRBme69Te+u8NOn1wC7Jc8ztqX0jgJ1E+y=g+2VD=E7GA@mail.gmail.com>
On Fri, Jun 10, 2022 at 08:07:58AM +0300, Alexander Shiyan wrote:
> чт, 9 июн. 2022 г. в 23:08, Michael Riesch <michael.riesch@wolfvision.net>:
> >
> > Hi Alexander,
> > On 6/8/22 07:12, Alexander Shiyan wrote:
> > > of_get_reset_source_priority() has no users,
> > > so it can be safely removed.
> > >
> > > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> > > ---
> > > common/reset_source.c | 20 +++-----------------
> > > include/reset_source.h | 7 -------
> > > 2 files changed, 3 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/common/reset_source.c b/common/reset_source.c
> > > index 3554cbd0fb..dccb683231 100644
> > > --- a/common/reset_source.c
> > > +++ b/common/reset_source.c
> > > @@ -76,7 +76,9 @@ EXPORT_SYMBOL(reset_source_set_prinst);
> > >
> > > void reset_source_set_device(struct device_d *dev, enum reset_src_type st)
> > > {
> > > - int priority = of_get_reset_source_priority(dev->device_node);
> > > + unsigned int priority = RESET_SOURCE_DEFAULT_PRIORITY;
> > > +
> > > + of_property_read_u32(node, "reset-source-priority", &priority);
> >
> > This seems to break my build:
> > barebox/common/reset_source.c:81:30: error: 'node' undeclared (first use
> > in this function)
> > 81 | of_property_read_u32(node, "reset-source-priority",
> > &priority);
> > | ^~~~
> >
> > Should "node" be replaced by "dev->device_node"?
>
> Hello.
>
> You're right.
> Unfortunately, I do not yet see this patch in the next branch to create a fixup.
I fixed it up. Check latest next branch
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-06-10 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 5:12 Alexander Shiyan
2022-06-09 7:32 ` Sascha Hauer
2022-06-09 7:38 ` Alexander Shiyan
2022-06-09 8:40 ` Sascha Hauer
2022-06-09 20:07 ` Michael Riesch
2022-06-10 5:07 ` Alexander Shiyan
2022-06-10 7:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610073232.GB1615@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
--cc=michael.riesch@wolfvision.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox