mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [RFC 1/2] clocksource: Introduce a context storage for the clocksource structure
Date: Fri, 10 Jun 2022 11:44:46 +0200	[thread overview]
Message-ID: <20220610094446.GN1615@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvR5o5GnKzkALRHd5BbR=mewE0u34xEMaVnj=ix2CEryGA@mail.gmail.com>

On Fri, Jun 10, 2022 at 12:42:58PM +0300, Alexander Shiyan wrote:
> пт, 10 июн. 2022 г. в 12:35, Sascha Hauer <sha@pengutronix.de>:
> >
> > On Fri, Jun 10, 2022 at 11:56:31AM +0300, Alexander Shiyan wrote:
> > > This patch adds a context entry for the clocksource structure.
> > > This field can be used to store any private driver data, and to
> > > distinguish between multiple driver instances for debugging purposes.
> >
> > You could embed struct clocksource in a private struct and use
> > container_of() to get that from the struct clocksource *.
> 
> Oh sure. But even in this case, we need to pass the pointer of the
> clocksource structure to the read() function.

Indeed. I didn't notice this change in your patch. That part would be
useful

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2022-06-10  9:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  8:56 Alexander Shiyan
2022-06-10  8:56 ` [RFC 2/2] clocksource: arm_global_timer: Convert driver to use clocksource context field Alexander Shiyan
2022-06-10  9:40   ` Sascha Hauer
2022-06-10  9:53     ` Alexander Shiyan
2022-06-10  8:56 ` [RFC 0/2] Context storage for the clocksource Alexander Shiyan
2022-06-10  9:35 ` [RFC 1/2] clocksource: Introduce a context storage for the clocksource structure Sascha Hauer
2022-06-10  9:42   ` Alexander Shiyan
2022-06-10  9:44     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610094446.GN1615@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox