From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 04 Jul 2022 16:19:39 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o8MvH-005bmW-TS for lore@lore.pengutronix.de; Mon, 04 Jul 2022 16:19:39 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8MvK-00063S-9A for lore@pengutronix.de; Mon, 04 Jul 2022 16:19:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=kk8zYdtfMFieyaIebfWsXH29Mfw4kCNrco4r7qhfvwc=; b=cyWbS9zdfKyzYMMhV4jFQU7E4F shJ5RGbqPtv+iMpiwDMAgK0ZHzAqEXXaI5FfUfUs3Ocqs3HQCd+KV9Z28HWuQauQFtz3RBnQCmtZJ Nu/xnm9e8lPaYTVwOwMRjM1zF/rK2UKNlWhkxGrpIIaJ0JbdUH47oNVZGByiWcnqwdQmFY7sVeQMi 2jfEH4pizQdow2BA01PLo3Qty+QH3KiJBcfpM5POc00JFH21kxxSsBOBkiQ+rZmi+tTYB2dd3k6ER jxWmvje7BzmQ6IZEProEnAnLbB+1VgwGi0vD4RM7pxLzBGcQTkCaFRQrBDBt+p7u596lNdygNKP44 kFQq0Iaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8Mu3-009PSe-47; Mon, 04 Jul 2022 14:18:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8Mty-009PRx-Rk for barebox@lists.infradead.org; Mon, 04 Jul 2022 14:18:16 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Mtw-0005gg-Sn for barebox@lists.infradead.org; Mon, 04 Jul 2022 16:18:12 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8Mts-004OCN-Ln for barebox@lists.infradead.org; Mon, 04 Jul 2022 16:18:12 +0200 Received: from mfe by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8Mtv-001uwC-8Y for barebox@lists.infradead.org; Mon, 04 Jul 2022 16:18:11 +0200 From: Marco Felsch To: barebox@lists.infradead.org Date: Mon, 4 Jul 2022 16:18:09 +0200 Message-Id: <20220704141809.457135-1-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_071814_941775_DA2C6BCD X-CRM114-Status: UNSURE ( 8.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] common: bootm: print error in case of appendroot failed X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Inform the user that appendroot failed instead of silently dropping the request. This makes the debugging easier e.g. if nt-signature wasn't set correctly. Signed-off-by: Marco Felsch --- common/bootm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/bootm.c b/common/bootm.c index 3c80e8bf94..1c722afc80 100644 --- a/common/bootm.c +++ b/common/bootm.c @@ -729,6 +729,8 @@ int bootm_boot(struct bootm_data *bootm_data) globalvar_add_simple("linux.bootargs.bootm.appendroot", rootarg); free(rootarg); + } else { + pr_err("Failed to append kernel cmdline parameter 'root='\n"); } } -- 2.30.2