From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 04 Jul 2022 17:02:52 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o8Nb7-005cp0-00 for lore@lore.pengutronix.de; Mon, 04 Jul 2022 17:02:52 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Nb8-0003GQ-L2 for lore@pengutronix.de; Mon, 04 Jul 2022 17:02:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0DE/TpL2ZJVdbhZNZDPyRRemUUl7xFLrhTFr9yzfwoc=; b=kPcJZ+Z+rHWepDkcjcP3jtsNDM xG4H+kYV+KaWt2zkwCDxzoD9KvoO4anCRuIv5sxX/D6DADdS9p1QI8zfZBr+mEeey4R8sQfWpqDOl mThrnopK4Ln88ZFTkeEoyaUW4171TBIGYkz1o0GBv+1lXOVMO0c3oYLfJGdjByt5FKM/ZxeCfSLR+ ZMsOHC/PWYDmNec1+UATsDXhIvd7h/jlbUfBuqL0VBfuO/ZppVt8RrXYovGINSMeRzZLUHN1jWENh g7efD+F0o12XelMOfN9mV1ke2xpyvta5oTHRrN4DF8pCUOQW9apOuNFypUwNSZQRtu3CvqneoGfdJ TT92TX3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8NZl-009aGb-Uo; Mon, 04 Jul 2022 15:01:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8NZg-009aEb-90 for barebox@lists.infradead.org; Mon, 04 Jul 2022 15:01:22 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8NZe-0003BL-SL; Mon, 04 Jul 2022 17:01:18 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1o8NZe-0001OC-JI; Mon, 04 Jul 2022 17:01:18 +0200 Date: Mon, 4 Jul 2022 17:01:18 +0200 From: Marco Felsch To: Lucas Stach Cc: barebox@lists.infradead.org Message-ID: <20220704150118.74ljreij2w5iwfun@pengutronix.de> References: <20220704142700.467654-1-m.felsch@pengutronix.de> <322469f9cbc5b7008001330354b19a0f1ff2c1cd.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <322469f9cbc5b7008001330354b19a0f1ff2c1cd.camel@pengutronix.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_080120_350951_459C3CB8 X-CRM114-Status: GOOD ( 28.78 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] ARM: i.MX8MP: adapt atf bl31 base addr X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 22-07-04, Lucas Stach wrote: > Am Montag, dem 04.07.2022 um 16:27 +0200 schrieb Marco Felsch: > > The usptream TF-A was shifting around the base address from version to > > version. But finally with upstream TF-A v2.7 it is correctly set to > > 0x970000. This change was done since the first official silicon has an > > SRAM size of 576KB where as the tapeout version A1 (pre-silicion) had > > only 512KB. > > Now this doesn't match the commit message in the TF-A, which claims > that tapeout A0 (pre-release silicon) had 512K SRAM, while it was > extended to 576KB in the A1 tapeout, which is the current mass produced > version. Arg.. sry. I got your prev. comment wrong. Should have checked the tf-a log twice. Sorry for the noise. > > > > The upstream TF-A has adapt it in verion v2.5 so the BL31 blob is at the > ^ adapted ^version > > end of the SRAM. Unfortunately they had (accidental) reverted back to > > Who is they? "Unfortunately it was reverted back..." The TF-A developers which are by name: - Ying-Chun Liu (PaulLiu) - Peng Fan - Jacky Bai But yes, I will drop they. > > 0x960000 in v2.6. They noticed that and changed (again) back to 0x970000. > > with v2.7. > > > > This commit also adapts the documentation for the i.MX8MP-EVK to > > reference the upstream TF-A. The new warning should point out that we > > strongly recommended to use versions from v2.7 onwards, due to the > ^ recommend Yes. > > version mess explained above. > > > > Signed-off-by: Marco Felsch > > --- > > Changelog: > > > > v2: > > - fix commit message ger/eng mixup and mention tapeout version A1 > > > > Documentation/boards/imx/nxp-imx8mp-evk.rst | 11 +++++++---- > > arch/arm/mach-imx/include/mach/atf.h | 2 +- > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/boards/imx/nxp-imx8mp-evk.rst b/Documentation/boards/imx/nxp-imx8mp-evk.rst > > index 366c1de500..1074992f2f 100644 > > --- a/Documentation/boards/imx/nxp-imx8mp-evk.rst > > +++ b/Documentation/boards/imx/nxp-imx8mp-evk.rst > > @@ -40,15 +40,18 @@ As a last step of this process those files need to be placed in > > firmware/${f}; \ > > done > > > > -Get and Build the ARM Trusted firmware > > --------------------------------------- > > +Get and Build the Trusted Firmware A > > +------------------------------------ > > > > -Get ATF from https://source.codeaurora.org/external/imx/imx-atf, branch > > -imx_5.4.3_2.0.0:: > > +Get TF-A from https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/ and > > +checkout version v2.7:: > > > > make PLAT=imx8mp bl31 > > cp build/imx8mp/release/bl31.bin ${barebox_srctree}/imx8mp-bl31.bin > > > > +.. warning:: It is important to use a version >= v2.7 else your system > > + might not boot. > > This doesn't tell anyone what's going on, I think we can bother the > reader with the details: "It is important to use a version >= v2.7, as > Barebox expects the BL31 SRAM load address used from this release > onwards." > > > + > > Build Barebox > > ------------- > > > > diff --git a/arch/arm/mach-imx/include/mach/atf.h b/arch/arm/mach-imx/include/mach/atf.h > > index 09396f4646..bc400ddbad 100644 > > --- a/arch/arm/mach-imx/include/mach/atf.h > > +++ b/arch/arm/mach-imx/include/mach/atf.h > > @@ -10,7 +10,7 @@ > > > > #define MX8MM_ATF_BL31_BASE_ADDR 0x00920000 > > #define MX8MN_ATF_BL31_BASE_ADDR 0x00960000 > > -#define MX8MP_ATF_BL31_BASE_ADDR 0x00960000 > > +#define MX8MP_ATF_BL31_BASE_ADDR 0x00970000 > > #define MX8MQ_ATF_BL31_BASE_ADDR 0x00910000 > > #define MX8M_ATF_BL33_BASE_ADDR 0x40200000 > > #define MX8MM_ATF_BL33_BASE_ADDR MX8M_ATF_BL33_BASE_ADDR > > >