Regression in automount between 2021.07.0 and 2022.05.0

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

Hello,

while updating barebox from 2021.07.0 to 2022.05.0 I hit a regression:

The behaviour of 2022.05.0 looks as follows:

	bootloader: automount -d /mnt/usbstorage 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; fi'
	bootloader: ls /mnt/usbstorage/

Without an USB drive this hangs until the watchdog resets the board. I
guess the problem is that the automount script is called again and again
because nothing was mounted.

I can workaround that problem by doing:

	bootloader: automount -d /mnt/usbstorage 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi'
	bootloader: ls /mnt/usbstorage/
	running automount command 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi' failed
	ls: /mnt/usbstorage/: No such device
	running automount command 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi' failed

but there is still something non-optimal.

I can look into that, but I'm not entirely sure what the right behaviour
is.

Should a command that doesn't mount something considered to have failed?
(I think that's how it was with 2021.07.0.)

Even when making the command fail, it's run twice, is this worth
investigating/fixing?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]