mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 6/6] kbuild: pbl: use same compression algo for both barebox and DTB
Date: Fri, 15 Jul 2022 12:53:18 +0200	[thread overview]
Message-ID: <20220715105318.GO2387@pengutronix.de> (raw)
In-Reply-To: <20220713095730.1878941-6-a.fatoum@pengutronix.de>

Hi Ahmad,

On Wed, Jul 13, 2022 at 11:57:30AM +0200, Ahmad Fatoum wrote:
> From: Ahmad Fatoum <ahmad@a3f.at>
> 
> lzop hasn't seen any activity since 2017 and has been recently removed
> from OpenEmbedded, which is unfortunate as we unconditionally use LZO
> for compressing device trees that are referenced via __dtb_z_.
> 
> To make barebox easier to integrate, use the same compression algorithm
> for both barebox and compressed DTB.
> 
> Note that the decompressor code will be in the image twice: Once in PBL
> in uncompressed form to decompress barebox proper and once in compressed
> form to decompress the DTB.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>   - drop LZO/LZ4 hardcoding with autodetection, instead use same algo for both
> ---
>  arch/arm/cpu/start.c | 11 ++++++++---
>  images/Makefile      |  6 ------
>  pbl/Kconfig          |  5 ++++-
>  scripts/Makefile.lib | 11 ++++++++++-
>  4 files changed, 22 insertions(+), 11 deletions(-)

This patch breaks compilation of virt2real_defconfig:

/bin/sh: 1: Syntax error: ";" unexpected
make[1]: *** [scripts/Makefile.lib:349: arch/arm/dts/virt2real.dtb.z] Error 2
make: *** [Makefile:953: arch/arm/dts] Error 2
make: *** Waiting for unfinished jobs....

I haven't looked into it yet.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2022-07-15 10:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  9:57 [PATCH v2 1/6] common: don't allow compressing in-barebox binaries again Ahmad Fatoum
2022-07-13  9:57 ` [PATCH v2 2/6] pbl: make USE_COMPRESSED_DTB a PBL-only feature Ahmad Fatoum
2022-07-13  9:57 ` [PATCH v2 3/6] pbl: remove redundant select UNCOMRPESS Ahmad Fatoum
2022-07-13  9:57 ` [PATCH v2 4/6] kbuild: gen-dtb-s: use Makefile.lib instead of duplicating cmd_lzo Ahmad Fatoum
2022-07-13  9:57 ` [PATCH v2 5/6] pbl: compressed-dtb: use flexible array member to access data Ahmad Fatoum
2022-07-13  9:57 ` [PATCH v2 6/6] kbuild: pbl: use same compression algo for both barebox and DTB Ahmad Fatoum
2022-07-15 10:53   ` Sascha Hauer [this message]
2022-07-15 15:57     ` [PATCH] fixup! " Ahmad Fatoum
2022-07-14  8:08 ` [PATCH v2 1/6] common: don't allow compressing in-barebox binaries again Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220715105318.GO2387@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH v2 6/6] kbuild: pbl: use same compression algo for both barebox and DTB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox