From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 09 Aug 2022 11:33:58 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oLLca-00HDKT-1x for lore@lore.pengutronix.de; Tue, 09 Aug 2022 11:33:58 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLLca-0006Jt-RB for lore@pengutronix.de; Tue, 09 Aug 2022 11:33:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dIs4RKHkdBz2SWjUsaCGSWDrLYiSfeQ1Mov4Vsb0sao=; b=EatsEEJayrhuwxTxXsr91hbARw mG5HReShjlbLQJCYs0R7WPD+vkKXSS8o59d0gUyFTHC0bkC6r7XrBV0Zj3sPwa7U19nA7sAC2imT8 yNzNHM+Saqe0X8HOH1uN01trwb9RlK/fecyxZPsKxUjkEkSBvsgQpvkMgmiWMQ+HDfPuFqcfXHeX8 0THbD0KZQFaybIPrhITf2CQ0wWmre5VKuogCJnucc2YRRjm+hXaNPbZMcAQfK0p823UWS3NYtHt/V 7DizPBDZ4VWKSejcynuLtAwC9g8veIgOkZWCunM0QgiZRFuWI9kauMgV7dZoGbgIuqnRWzL3FDmof TmUSPRyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLLbK-0034A7-2s; Tue, 09 Aug 2022 09:32:38 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLLbE-003491-EU for barebox@lists.infradead.org; Tue, 09 Aug 2022 09:32:34 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLLbA-0006Ax-FO; Tue, 09 Aug 2022 11:32:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oLLbA-0008O4-6g; Tue, 09 Aug 2022 11:32:28 +0200 Date: Tue, 9 Aug 2022 11:32:28 +0200 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20220809093228.GN31528@pengutronix.de> References: <20220809062422.1749563-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220809062422.1749563-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220809_023232_507201_26E6F932 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 1/4] net: designware: rework Kconfig text and menu structure X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Tue, Aug 09, 2022 at 08:24:19AM +0200, Ahmad Fatoum wrote: > Instead of depending on the common code being enabled, just select it if > needed and reword the Kconfig text to fix some typos and to make > configuration easier. > > Signed-off-by: Ahmad Fatoum > --- > drivers/net/Kconfig | 64 ++++++++++++++++++++++++--------------------- > 1 file changed, 34 insertions(+), 30 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 803444cc44a4..341d02a1da5e 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -55,71 +55,75 @@ config DRIVER_NET_DAVINCI_EMAC > select PHYLIB > > config DRIVER_NET_DESIGNWARE > - bool "Designware Universal MAC1000 ethernet platform support" > + bool "Designware DWMAC1000 Ethernet driver support" if COMPILE_TEST > depends on HAS_DMA > select PHYLIB > help > - This option enables support for the Synopsys > - Designware Core Univesal MAC 10M/100M/1G ethernet IP. > - > -if DRIVER_NET_DESIGNWARE > + This option is selected by platform glue drivers that contain > + a DWMAC1000-compatible Ethernet IP. > > config DRIVER_NET_DESIGNWARE_GENERIC > - bool "Designware Universal MAC ethernet generic driver" > + bool "Generic Synopsis Designware Ethernet driver" > + select DRIVER_NET_DESIGNWARE > + depends on HAS_DMA > help > - This option enables support for the Synopsys > - Designware Core Univesal MAC 10M/100M/1G ethernet IP on SoCFPGA. > + This option enables support for the generic Synopsys > + Designware Core Universal MAC 10M/100M/1G binding. Supported > + are 3.70a and 3.72. Most integrations additionally require > + access to platform-specific registers, e.g. for clocking. > + If you are on such a platform, use the platform specific > + driver instead. > > config DRIVER_NET_DESIGNWARE_SOCFPGA > - bool "Designware Universal MAC ethernet driver for SoCFPGA platforms" > - depends on ARCH_SOCFPGA || COMPILE_TEST > + bool "SOCFPGA Designware Ethernet driver" > + depends on HAS_DMA && (ARCH_SOCFPGA || COMPILE_TEST) > + select DRIVER_NET_DESIGNWARE > select MFD_SYSCON > select RESET_CONTROLLER > help > This option enables support for the Synopsys > - Designware Core Univesal MAC 10M/100M/1G ethernet IP on SoCFPGA. > + Designware Core Universal MAC 10M/100M/1G Ethernet IP on SoCFPGA. > > config DRIVER_NET_DESIGNWARE_STARFIVE > - bool "Designware Universal MAC ethernet driver for StarFive platforms" > - depends on SOC_STARFIVE || COMPILE_TEST > + bool "StarFive Designware Ethernet driver" > + depends on HAS_DMA && (SOC_STARFIVE || COMPILE_TEST) > + select DRIVER_NET_DESIGNWARE > select MFD_SYSCON > help > This option enables support for the Synopsys > - Designware Core Univesal MAC 10M/100M/1G ethernet IP on StarFive. > - > -endif > + Designware Core Universal MAC 10M/100M/1G Ethernet IP on StarFive. > > config DRIVER_NET_DESIGNWARE_EQOS > - bool "Designware Designware Ethernet QoS support" > - depends on HAS_DMA > - depends on COMMON_CLK > - depends on OFTREE > + bool "Designware EQOS (GMAC4) Ethernet driver support" if COMPILE_TEST > + depends on HAS_DMA && OFTREE > select PHYLIB > help > This option enables support for the Synopsys > Designware Ethernet Quality-of-Service (GMAC4). > > -if DRIVER_NET_DESIGNWARE_EQOS > - > config DRIVER_NET_DESIGNWARE_STM32 > - bool "Designware EQOS STM32 driver" > + bool "STM32 Designware Ethernet driver" > + depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_STM32MP || COMPILE_TEST) > + select DRIVER_NET_DESIGNWARE_EQOS > select MFD_SYSCON > help > - This option enables support for the ethernet MAC on the STM32MP platforms. > + This option enables support for the Ethernet MAC on the STM32MP platforms. > > config DRIVER_NET_DESIGNWARE_TEGRA186 > - bool "Designware Universal MAC ethernet driver for Tegra 186 platforms" > + bool "Tegra 186/194 Designware Ethernet driver" > + depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_TEGRA || COMPILE_TEST) > + select DRIVER_NET_DESIGNWARE_EQOS > select RESET_CONTROLLER > help > - This option enables support for the ethernet MAC on the Tegra186 & 194. > + This option enables support for the Ethernet MAC on the Tegra186 & 194. > > config DRIVER_NET_DESIGNWARE_ROCKCHIP > - bool "Designware Universal MAC ethernet driver for Rockchip platforms" > + bool "Rockchip Designware Ethernet driver" > + select DRIVER_NET_DESIGNWARE_EQOS > + depends on HAS_DMA && COMMON_CLK && OFTREE && (ARCH_ROCKCHIP || COMPILE_TEST) > select MFD_SYSCON > help > - This option enables support for the ethernet MAC on different Rockchip SoCs > - > -endif > + This option enables support for the Ethernet MAC on different Rockchip SoCs > > config DRIVER_NET_DM9K > bool "Davicom dm9k[E|A|B] ethernet driver" > -- > 2.30.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |